[Data] Allow generator UDFs for map_batches and flat_map
#32767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amogkam
changed the title
map_batchesmap_batches and map
amogkam
requested review from
ericl,
scv119,
clarkzinzow,
jjyao,
jianoaix,
maxpumperla,
c21 and
a team
as code owners
richardliaw
approved these changes
Feb 26, 2023
| =================== | ||
| Types of UDFs | ||
| ============= | ||
| .. tabbed:: "Function UDFs" |
There was a problem hiding this comment.
before the tab, can you mention a summary statement - ie "There are three types of UDFs that you can use with Ray Data: Function ..."
ericl
reviewed
Feb 27, 2023
ericl
reviewed
Feb 27, 2023
ericl
added
the
@author-action-required
ericl
approved these changes
Feb 27, 2023
c21
approved these changes
Feb 27, 2023
There was a problem hiding this comment.
LGTM w/ minor comments. Also cc @clarkzinzow for related zero-copy batching work. thanks.
clarkzinzow
approved these changes
Feb 27, 2023
There was a problem hiding this comment.
LGTM! @c21 I'll be sure to port this to the zero-copy fusion adapters PR.
Signed-off-by: amogkam <amogkamsetty@yahoo.com>
amogkam
changed the title
map_batches and mapmap_batches and flat_map
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
Mar 21, 2023
…ject#32767) UDFs may return very large objects (for example when converting videos stored as bytes into multiple tensors for each window frame). This can lead to large amounts of heap memory usage and possibly cause OOMs. By allowing generator UDFs, users can instead yield chunks of the large object at a time. Closes ray-project#32746 --------- Signed-off-by: amogkam <amogkamsetty@yahoo.com> Signed-off-by: Jack He <jackhe2345@gmail.com>
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
…ject#32767) UDFs may return very large objects (for example when converting videos stored as bytes into multiple tensors for each window frame). This can lead to large amounts of heap memory usage and possibly cause OOMs. By allowing generator UDFs, users can instead yield chunks of the large object at a time. Closes ray-project#32746 --------- Signed-off-by: amogkam <amogkamsetty@yahoo.com> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
peytondmurray
pushed a commit
to peytondmurray/ray
that referenced
this pull request
Mar 22, 2023
…ject#32767) UDFs may return very large objects (for example when converting videos stored as bytes into multiple tensors for each window frame). This can lead to large amounts of heap memory usage and possibly cause OOMs. By allowing generator UDFs, users can instead yield chunks of the large object at a time. Closes ray-project#32746 --------- Signed-off-by: amogkam <amogkamsetty@yahoo.com>
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
…ject#32767) UDFs may return very large objects (for example when converting videos stored as bytes into multiple tensors for each window frame). This can lead to large amounts of heap memory usage and possibly cause OOMs. By allowing generator UDFs, users can instead yield chunks of the large object at a time. Closes ray-project#32746 --------- Signed-off-by: amogkam <amogkamsetty@yahoo.com> Signed-off-by: elliottower <elliot@elliottower.com>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
…ject#32767) UDFs may return very large objects (for example when converting videos stored as bytes into multiple tensors for each window frame). This can lead to large amounts of heap memory usage and possibly cause OOMs. By allowing generator UDFs, users can instead yield chunks of the large object at a time. Closes ray-project#32746 --------- Signed-off-by: amogkam <amogkamsetty@yahoo.com> Signed-off-by: Jack He <jackhe2345@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UDFs may return very large objects (for example when converting videos stored as bytes into multiple tensors for each window frame). This can lead to large amounts of heap memory usage and possibly cause OOMs.
By allowing generator UDFs, users can instead yield chunks of the large object at a time.
Closes #32746
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.