Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage_lib.LibUsageRecorder #32806

Merged
merged 1 commit into from
Feb 25, 2023
Merged

Remove usage_lib.LibUsageRecorder #32806

merged 1 commit into from
Feb 25, 2023

Conversation

jjyao
Copy link
Collaborator

@jjyao jjyao commented Feb 24, 2023

Why are these changes needed?

#25842 is not needed since we will no longer accidentally create a new cluster while an existing one is running after #26678

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
@rkooo567 rkooo567 added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Feb 24, 2023
@jjyao jjyao removed the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Feb 24, 2023
@ericl ericl merged commit 92ef37d into ray-project:master Feb 25, 2023
@jjyao jjyao deleted the jjyao/red branch February 25, 2023 04:24
edoakes pushed a commit to edoakes/ray that referenced this pull request Mar 22, 2023
ray-project#25842 is not needed since we will no longer accidentally create a new cluster while an existing one is running after ray-project#26678

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
peytondmurray pushed a commit to peytondmurray/ray that referenced this pull request Mar 22, 2023
ray-project#25842 is not needed since we will no longer accidentally create a new cluster while an existing one is running after ray-project#26678
elliottower pushed a commit to elliottower/ray that referenced this pull request Apr 22, 2023
ray-project#25842 is not needed since we will no longer accidentally create a new cluster while an existing one is running after ray-project#26678

Signed-off-by: elliottower <elliot@elliottower.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants