[Datasets] Fix from_items parallelism to create the expected number of blocks.
#32821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clarkzinzow
requested review from
ericl,
scv119,
jjyao,
jianoaix and
c21
as code owners
clarkzinzow
changed the title
from_items parallelism to create the expected number of blocks.
ericl
approved these changes
Feb 24, 2023
ericl
added
the
@author-action-required
jianoaix
approved these changes
Feb 24, 2023
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
… of blocks. (ray-project#32821) Before this PR, when constructing blocks in alignment with the parallelism arg, from_items() used a buggy "calculate quotient and split on it" route which produced, when num_rows % parallelism != 0, both (1) more blocks than expected and (2) produced suboptimally balanced blocks. This PR fixes from_items() block construction by (1) always created parallelism blocks unless num_rows < parallelism, at which point we truncate the number of blocks to num_rows, and (2) evenly distributing the num_rows % parallelism remainder across the parallelism blocks while preserving record order. Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
peytondmurray
pushed a commit
to peytondmurray/ray
that referenced
this pull request
Mar 22, 2023
… of blocks. (ray-project#32821) Before this PR, when constructing blocks in alignment with the parallelism arg, from_items() used a buggy "calculate quotient and split on it" route which produced, when num_rows % parallelism != 0, both (1) more blocks than expected and (2) produced suboptimally balanced blocks. This PR fixes from_items() block construction by (1) always created parallelism blocks unless num_rows < parallelism, at which point we truncate the number of blocks to num_rows, and (2) evenly distributing the num_rows % parallelism remainder across the parallelism blocks while preserving record order.
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
… of blocks. (ray-project#32821) Before this PR, when constructing blocks in alignment with the parallelism arg, from_items() used a buggy "calculate quotient and split on it" route which produced, when num_rows % parallelism != 0, both (1) more blocks than expected and (2) produced suboptimally balanced blocks. This PR fixes from_items() block construction by (1) always created parallelism blocks unless num_rows < parallelism, at which point we truncate the number of blocks to num_rows, and (2) evenly distributing the num_rows % parallelism remainder across the parallelism blocks while preserving record order. Signed-off-by: elliottower <elliot@elliottower.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, when constructing blocks in alignment with the
parallelismarg,from_items()used a buggy "calculate quotient and split on it" route which produced, whennum_rows % parallelism != 0, both (1) more blocks than expected and (2) produced suboptimally balanced blocks. This PR fixesfrom_items()block construction by (1) always createdparallelismblocks unlessnum_rows < parallelism, at which point we truncate the number of blocks tonum_rows, and (2) evenly distributing thenum_rows % parallelismremainder across theparallelismblocks while preserving record order.Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.