-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ray Data] fix problem: to_pandas failed on datasets returned by from_spark #32968
Merged
Merged
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
8507826
fix
kira-lin fb30631
add a test to test to_pandas
kira-lin 9c82116
format
kira-lin a58cf5d
delete override add_block
kira-lin 520be87
Merge remote-tracking branch 'upstream/master' into fix-raydp-to-pd
kira-lin dabf3a5
Merge remote-tracking branch 'upstream/master' into fix-raydp-to-pd
kira-lin 2254b18
format
kira-lin 4f3860a
Merge remote-tracking branch 'upstream/master' into fix-raydp-to-pd
kira-lin 5e50f0b
Update python/ray/data/_internal/delegating_block_builder.py
kira-lin 5378779
remove unused import
kira-lin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kira-lin Why is this necessary? The existing
TableBlockBuilder.add_block()
logic should convert the bytes into an Arrow table: delegation, conversionIs this an issue with the instance check in
TableBlockBuilder.add_block()
? If so, we can change the block type supplied by theArrowBlockBuilder
constructor to its parent's constructor to a(pyarrow.Table, bytes)
tuple, sinceisinstance()
checks work with a tuple of types, andTableBlockBuilder._block_type
is only used for that instance check.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, I see. I tried Union, didn't work. but this alone is not enough to solve the problem. Please see the update.