Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[no_early_kickoff][Train] ray.train.huggingface restructure #33278

Merged
merged 45 commits into from
May 8, 2023
Merged

[no_early_kickoff][Train] ray.train.huggingface restructure #33278

merged 45 commits into from
May 8, 2023

Conversation

Yard1
Copy link
Member

@Yard1 Yard1 commented Mar 13, 2023 •
edited
Loading

Why are these changes needed?

Renames HuggingFaceTrainer/Predictor/Checkpoint to TransformersTrainer/Predictor/Checkpoint for clarity and moves them to ray.train.transformers. A soft deprecation is introduced so that the old location and names still work.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Yard1 added 8 commits March 13, 2023 20:27
@Yard1
WIP
4bcb4e3 
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
@Yard1
WIP
673cd80 
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
@Yard1
WIP
f4469e1 
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
@Yard1
Merge branch 'ray-project:master' into accelerate_trainer_2
e838585
@Yard1
WIP
5595dd3 
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
@Yard1
Fix
6bf6603 
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
@Yard1
Restructure ray.train.huggingface
fb333c9 
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
@Yard1
Merge branch 'master' into huggingface_restructure
1685593 
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
@Yard1 Yard1 marked this pull request as ready for review March 25, 2023 00:32
@Yard1
Fix
812cc08 
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
@Yard1 Yard1 requested a review from woshiyyya March 25, 2023 00:34
Yard1 added 2 commits March 25, 2023 00:40
@Yard1
Fix
a4dc374 
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
@Yard1
Fix
c6ebc40 
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
@Yard1 Yard1 changed the title [Train] ray.train.huggingface restructure [no_early_kickoff][Train] ray.train.huggingface restructure Mar 25, 2023
Yard1 added 17 commits April 17, 2023 18:30
@Yard1
Merge branch 'master' into huggingface_restructure
bf9d662 
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
@Yard1
Merge branch 'huggingface_restructure' of https://github.com/Yard1/ray …
ca88b8c 
…into huggingface_restructure
@Yard1
Allow local datasets in HuggingFaceTrainer
3d3e1ac 
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
@Yard1
Merge branch 'hf_trainer_allow_non_ray_datasets' into huggingface_res…
1fd2c53 
…tructure

Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
@Yard1
Clarify
56289d6 
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
@Yard1
Merge branch 'hf_trainer_allow_non_ray_datasets' into huggingface_res…
daa8e66 
…tructure

Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
@Yard1
Update
e785d2e 
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
@Yard1
Merge branch 'master' into huggingface_restructure
c9c5203 
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
@Yard1
Merge branch 'ray-project:master' into huggingface_restructure
4696da2
@Yard1
Tweak docs
34cf027 
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
@Yard1
Merge branch 'master' into huggingface_restructure
ac8e23b
@Yard1
Change paths
39507c9 
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
@Yard1
Add alias
cfe66a9 
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
@Yard1
Remove transformers alias
cf9b54b 
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
@Yard1
Rename to hf_transformers
969bde1 
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
@Yard1
Fix
2680826 
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
@Yard1
Fix
076bec6 
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
richardliaw
richardliaw approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@richardliaw richardliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamp

@Yard1 Yard1 merged commit 1512612 into ray-project:master May 8, 2023
@Yard1 Yard1 deleted the huggingface_restructure branch May 8, 2023 19:58
This was referenced May 11, 2023
Merged
Merged
architkulkarni pushed a commit to architkulkarni/ray that referenced this pull request May 16, 2023
@Yard1 @architkulkarni
[no_early_kickoff][Train] ray.train.huggingface restructure (ray-pr…
7c2469c 
…oject#33278)

Renames HuggingFaceTrainer/Predictor/Checkpoint to TransformersTrainer/Predictor/Checkpoint for clarity and moves them to ray.train.transformers. A soft deprecation is introduced so that the old location and names still work.

---------

Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woshiyyya woshiyyya woshiyyya approved these changes

@richardliaw richardliaw richardliaw approved these changes

@gjoliver gjoliver Awaiting requested review from gjoliver

@krfricke krfricke Awaiting requested review from krfricke

@xwjiang2010 xwjiang2010 Awaiting requested review from xwjiang2010

@amogkam amogkam Awaiting requested review from amogkam

@matthewdeng matthewdeng Awaiting requested review from matthewdeng matthewdeng is a code owner

@maxpumperla maxpumperla Awaiting requested review from maxpumperla

Assignees

@matthewdeng matthewdeng

@gjoliver gjoliver

@amogkam amogkam

@woshiyyya woshiyyya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Yard1 @ollie-iterators @richardliaw @woshiyyya @matthewdeng @gjoliver @amogkam