Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Fix lint and linkcheck failures #33334

Merged
merged 3 commits into from
Mar 15, 2023
Merged

[CI] Fix lint and linkcheck failures #33334

merged 3 commits into from
Mar 15, 2023

Conversation

Yard1
Copy link
Member

@Yard1 Yard1 commented Mar 15, 2023 •
edited
Loading

Signed-off-by: Antoni Baum antoni.baum@protonmail.com

Why are these changes needed?

Fixes lint and linkcheck failing on master

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Yard1 added 2 commits March 15, 2023 18:29
@Yard1
[CI] Fix lint failure
a941ec9 
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
@Yard1
Fix linkcheck
8b6378d 
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
@Yard1 Yard1 changed the title [CI] Fix lint failure [CI] Fix lint and linkcheck failures Mar 15, 2023
@krfricke krfricke merged commit ed960a7 into ray-project:master Mar 15, 2023
@scottjlee scottjlee mentioned this pull request Mar 15, 2023
Merged
7 tasks
@Yard1 Yard1 deleted the fix_lint branch March 15, 2023 21:17
@zcin zcin mentioned this pull request Mar 16, 2023
Merged
7 tasks
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request Mar 21, 2023
@Yard1 @ProjectsByJackHe
[CI] Fix lint and linkcheck failures (ray-project#33334)
7b42273 
Fixes lint and linkcheck failing on master

Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
Signed-off-by: Jack He <jackhe2345@gmail.com>
edoakes pushed a commit to edoakes/ray that referenced this pull request Mar 22, 2023
@Yard1 @edoakes
[CI] Fix lint and linkcheck failures (ray-project#33334)
8bfd754 
Fixes lint and linkcheck failing on master

Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
peytondmurray pushed a commit to peytondmurray/ray that referenced this pull request Mar 22, 2023
@Yard1 @peytondmurray
[CI] Fix lint and linkcheck failures (ray-project#33334)
c086b36 
Fixes lint and linkcheck failing on master

Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
elliottower pushed a commit to elliottower/ray that referenced this pull request Apr 22, 2023
@Yard1 @elliottower
[CI] Fix lint and linkcheck failures (ray-project#33334)
7444137 
Fixes lint and linkcheck failing on master

Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
Signed-off-by: elliottower <elliot@elliottower.com>
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
@Yard1 @ProjectsByJackHe
[CI] Fix lint and linkcheck failures (ray-project#33334)
51f1958 
Fixes lint and linkcheck failing on master

Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
Signed-off-by: Jack He <jackhe2345@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krfricke krfricke krfricke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yard1 @krfricke