-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core][deps] pin json-schema < 4.18 #33412
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exclude from the prerelease test as well? ray/ci/env/install-core-prerelease-dependencies.sh Lines 7 to 10 in 41c3b1e
|
scv119
changed the title
[Core] pin json-schema < 4.18
[Core][deps] pin json-schema < 4.18
Mar 17, 2023
clarng
approved these changes
Mar 17, 2023
cadedaniel
approved these changes
Mar 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all test failures appear unrelated
scv119
added a commit
to scv119/ray
that referenced
this pull request
Mar 17, 2023
ray-project#33411 there is a risk ray client_server will crash with jsonschema >= 4.18
7 tasks
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
Mar 21, 2023
ray-project#33411 there is a risk ray client_server will crash with jsonschema >= 4.18 Signed-off-by: Jack He <jackhe2345@gmail.com>
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
ray-project#33411 there is a risk ray client_server will crash with jsonschema >= 4.18 Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
chaowanggg
pushed a commit
to chaowanggg/ray-dev
that referenced
this pull request
Apr 4, 2023
ray-project#33411 there is a risk ray client_server will crash with jsonschema >= 4.18 Signed-off-by: chaowang <chaowang@anyscale.com>
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
ray-project#33411 there is a risk ray client_server will crash with jsonschema >= 4.18 Signed-off-by: elliottower <elliot@elliottower.com>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
ray-project#33411 there is a risk ray client_server will crash with jsonschema >= 4.18 Signed-off-by: Jack He <jackhe2345@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
#33411 there is a risk ray client_server will crash with jsonschema >= 4.18
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.