Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metrics] Improve the existing OOM metrics #33453

Merged
merged 4 commits into from
Mar 25, 2023
Merged

[Metrics] Improve the existing OOM metrics #33453

merged 4 commits into from
Mar 25, 2023

Conversation

rkooo567
Copy link
Contributor

@rkooo567 rkooo567 commented Mar 20, 2023 •
edited
Loading

Why are these changes needed?

This PR improves the existing metrics to have the task/class information.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@rkooo567
OOM metrics
1cc1d4d 
Signed-off-by: SangBin Cho <rkooo567@gmail.com>
@rkooo567 rkooo567 requested a review from a team as a code owner March 20, 2023 07:59
@rkooo567
Copy link
Contributor Author

Still testing...

rickyyx
rickyyx reviewed Mar 25, 2023
View reviewed changes
Copy link
Contributor

@rickyyx rickyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a screenshot or something? Or is the PR title not correct?

@rkooo567 rkooo567 changed the title [WIP][Metrics] Add the default OOM count dashboard [WIP][Metrics] Improve the existing OOM metrics Mar 25, 2023
@rkooo567 rkooo567 changed the title [WIP][Metrics] Improve the existing OOM metrics [Metrics] Improve the existing OOM metrics Mar 25, 2023
rickyyx
rickyyx approved these changes Mar 25, 2023
View reviewed changes
Copy link
Contributor

@rickyyx rickyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

real stamp this time...

@rkooo567 rkooo567 merged commit 4e64ef3 into ray-project:master Mar 25, 2023
elliottower pushed a commit to elliottower/ray that referenced this pull request Apr 22, 2023
@rkooo567 @elliottower
[Metrics] Improve the existing OOM metrics (ray-project#33453)
83bc716 
This PR improves the existing metrics to have the task/class information.

Signed-off-by: elliottower <elliot@elliottower.com>
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
@rkooo567 @ProjectsByJackHe
[Metrics] Improve the existing OOM metrics (ray-project#33453)
eb94a71 
This PR improves the existing metrics to have the task/class information.

Signed-off-by: Jack He <jackhe2345@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickyyx rickyyx rickyyx approved these changes

Assignees

@rickyyx rickyyx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkooo567 @rickyyx