Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[no_early_kickoff] [AIR] Make Keras Callback raise DeprecationWarning #33775

Merged
merged 31 commits into from
Mar 30, 2023
Merged

[no_early_kickoff] [AIR] Make Keras Callback raise DeprecationWarning #33775

merged 31 commits into from
Mar 30, 2023

Conversation

bveeramani
Copy link
Member

@bveeramani bveeramani commented Mar 27, 2023 •
edited
Loading

Why are these changes needed?

The Keras Callback was deprecated in Ray 2.3 in favor of ReportCheckpointCallback. This PR escalates the deprecation warning to a deprecation error.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

bveeramani and others added 22 commits November 21, 2022 21:00
@bveeramani
Rename "model_state_dict" to "model"
5984f1e
@bveeramani
Revert "Rename "model_state_dict" to "model""
8f58490 
This reverts commit 5984f1e.
@bveeramani
Merge remote-tracking branch 'upstream/master'
63432eb 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
2c33947 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
89694a0 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
fe60ca3 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
d45ae9a 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
c703dfc 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
81dd25c 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
fba788e 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Update annotations.py
de05655 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Revert "Update annotations.py"
fd2ff91 
This reverts commit de05655.

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
7c3ac36 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
9c7b546 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
9d7a15f 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
4f02efe 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
46f43d9 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
a644307 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
e5d0bf1 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
fe7286c 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
51b3a09 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Make Keras Callback raise DeprecationWarning
b5f5ec9 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani bveeramani requested a review from a team as a code owner March 27, 2023 23:39
@bveeramani
Merge remote-tracking branch 'upstream/master'
79f8be9 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge branch 'master' into deprecate-keras-callback
5386ffb 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani bveeramani changed the title [AIR] Make Keras Callback raise DeprecationWarning [no_early_kickoff] [AIR] Make Keras Callback raise DeprecationWarning Mar 28, 2023
@bveeramani
Create temp
482c466 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Delete temp
a82ebe7 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Update convert_existing_tf_code_to_ray_air.ipynb
1deb687 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@amogkam
Copy link
Contributor

amogkam commented Mar 28, 2023

looks like convert_existing_tf_code_to_ray_air example was missed

@bveeramani
Update convert_existing_tf_code_to_ray_air.ipynb
ed23743 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master' into deprecate-keras-c…
fd2638f 
…allback

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Update convert_existing_tf_code_to_ray_air.ipynb
94d3ef0 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Update convert_existing_tf_code_to_ray_air.ipynb
3d374b6 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani bveeramani added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Mar 30, 2023
zhe-thoughts
zhe-thoughts approved these changes Mar 30, 2023
View reviewed changes
Copy link
Collaborator

@zhe-thoughts zhe-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly docs change. Approved for merging into master

@amogkam amogkam merged commit 8278421 into ray-project:master Mar 30, 2023
can-anyscale pushed a commit that referenced this pull request Mar 30, 2023
@bveeramani @can-anyscale
[no_early_kickoff] [AIR] Make Keras Callback raise `DeprecationWarn…
f6833f4 
…ing` (#33775)

The Keras Callback was deprecated in Ray 2.3 in favor of ReportCheckpointCallback. This PR escalates the deprecation warning to a deprecation error.

---------

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
can-anyscale pushed a commit that referenced this pull request Mar 30, 2023
@bveeramani @can-anyscale
[no_early_kickoff] [AIR] Make Keras Callback raise `DeprecationWarn…
064d405 
…ing` (#33775)

The Keras Callback was deprecated in Ray 2.3 in favor of ReportCheckpointCallback. This PR escalates the deprecation warning to a deprecation error.

---------

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
elliottower pushed a commit to elliottower/ray that referenced this pull request Apr 22, 2023
@bveeramani @elliottower
[no_early_kickoff] [AIR] Make Keras Callback raise `DeprecationWarn…
d15d369 
…ing` (ray-project#33775)

The Keras Callback was deprecated in Ray 2.3 in favor of ReportCheckpointCallback. This PR escalates the deprecation warning to a deprecation error.

---------

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: elliottower <elliot@elliottower.com>
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
@bveeramani @ProjectsByJackHe
[no_early_kickoff] [AIR] Make Keras Callback raise `DeprecationWarn…
2494490 
…ing` (ray-project#33775)

The Keras Callback was deprecated in Ray 2.3 in favor of ReportCheckpointCallback. This PR escalates the deprecation warning to a deprecation error.

---------

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Jack He <jackhe2345@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardliaw richardliaw richardliaw approved these changes

@amogkam amogkam amogkam approved these changes

@zhe-thoughts zhe-thoughts zhe-thoughts approved these changes

@gjoliver gjoliver Awaiting requested review from gjoliver

@krfricke krfricke Awaiting requested review from krfricke

@xwjiang2010 xwjiang2010 Awaiting requested review from xwjiang2010

@matthewdeng matthewdeng Awaiting requested review from matthewdeng matthewdeng is a code owner

@Yard1 Yard1 Awaiting requested review from Yard1

@maxpumperla maxpumperla Awaiting requested review from maxpumperla

Assignees

@amogkam amogkam

@zhe-thoughts zhe-thoughts

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bveeramani @amogkam @richardliaw @zhe-thoughts