Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no_early_kickoff][train] Hard deprecate Backend encode_data/decode_data #33784

Merged
merged 3 commits into from
Mar 28, 2023

Conversation

matthewdeng
Copy link
Contributor

@matthewdeng matthewdeng commented Mar 28, 2023

Why are these changes needed?

These methods were soft deprecated in (Ray 2.2): #29785.

This PR hard deprecates these. In the future, we will completely remove these APIs along with the corresponding encode_data and decode_data methods as well as their usages (e.g. encode_data_fn).

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Matthew Deng <matt@anyscale.com>
Signed-off-by: Matthew Deng <matt@anyscale.com>
Copy link
Contributor

@amogkam amogkam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@matthewdeng matthewdeng changed the title [train] Hard deprecate Backend encode_data/decode_data [no_early_kickoff][train] Hard deprecate Backend encode_data/decode_data Mar 28, 2023
@matthewdeng matthewdeng added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Mar 28, 2023
@amogkam amogkam merged commit 2988a38 into ray-project:master Mar 28, 2023
elliottower pushed a commit to elliottower/ray that referenced this pull request Apr 22, 2023
…ata (ray-project#33784)

These methods were soft deprecated in (Ray 2.2): ray-project#29785.

This PR hard deprecates these. In the future, we will completely remove these APIs along with the corresponding encode_data and decode_data methods as well as their usages (e.g. encode_data_fn).

---------

Signed-off-by: Matthew Deng <matt@anyscale.com>
Signed-off-by: elliottower <elliot@elliottower.com>
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
…ata (ray-project#33784)

These methods were soft deprecated in (Ray 2.2): ray-project#29785.

This PR hard deprecates these. In the future, we will completely remove these APIs along with the corresponding encode_data and decode_data methods as well as their usages (e.g. encode_data_fn).

---------

Signed-off-by: Matthew Deng <matt@anyscale.com>
Signed-off-by: Jack He <jackhe2345@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants