[RLlin] Add dist_inputs to action sampler fn returns in TorchPolicyV2 #33795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
ArturNiederfahrenhorst
requested review from
sven1977,
gjoliver,
avnishn,
smorad,
maxpumperla,
kouroshHakha and
krfricke
as code owners
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
avnishn
approved these changes
Mar 29, 2023
gjoliver
approved these changes
Mar 30, 2023
can-anyscale
pushed a commit
that referenced
this pull request
Mar 30, 2023
…#33795) Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
can-anyscale
pushed a commit
that referenced
this pull request
Mar 30, 2023
…#33795) Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
…ray-project#33795) Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com> Signed-off-by: elliottower <elliot@elliottower.com>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
…ray-project#33795) Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com> Signed-off-by: Jack He <jackhe2345@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR adds the action distribution inputs to the values returned by self.action_sampler_fn in TorchPolicyV2.
Before, there where not enough values to unpack when
action_sampler_fnwas implemented correctly.I also explored unifying all
action_sampler_fnoccurrences in RLlib to four return values but I don't think that makes sense at this point. Most Policy classes will soon be deprecated anyway and we would be harddeprecating something (action_sampler_fn with three returns) that simply works for the time being.Fixes #33716