Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] DM control suite wrapper fix: dtype of obs needs to be pinned to float32. #33876

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Mar 29, 2023

DM control suite wrapper fix: dtype of observation returned by _get_obs() method needs to be pinned to float32.
If not, this might lead to a type mismatch (float32 matrix vs float64 observation) in a network that processes these observations, especially after an env reset.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977 sven1977 merged commit 8f3ee83 into ray-project:master Mar 31, 2023
elliottower pushed a commit to elliottower/ray that referenced this pull request Apr 22, 2023
… to float32. (ray-project#33876)

Signed-off-by: elliottower <elliot@elliottower.com>
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
… to float32. (ray-project#33876)

Signed-off-by: Jack He <jackhe2345@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants