Plasma C extensions #34
Conversation
| plasma_get(conn, object_id, &size, &data, &metadata_size, &metadata); | ||
| PyObject *t = PyTuple_New(2); | ||
| PyTuple_SetItem(t, 0, PyBuffer_FromReadWriteMemory((void *) data, size)); | ||
| PyTuple_SetItem(t, 1, PyBuffer_FromReadWriteMemory((void *) metadata, metadata_size)); |
There was a problem hiding this comment.
probably want PyBuffer_FromMemory, right?
pcmoritz
force-pushed
the
numbuf
branch
8 times, most recently
from
c0b8c09 to
00c0dc0
Compare
| popd | ||
| cp "$PLASMA_DIR/build/plasma_store" "$PYTHON_PLASMA_DIR/build/" | ||
| cp "$PLASMA_DIR/build/plasma_manager" "$PYTHON_PLASMA_DIR/build/" | ||
| cp "$PLASMA_DIR/build/plasma_client.so" "$PYTHON_PLASMA_DIR/build/" | ||
| cp "$PLASMA_DIR/lib/python/plasma.py" "$PYTHON_PLASMA_DIR/lib/python/" | ||
| cp "$PLASMA_DIR/build/libplasma.so" "$PYTHON_PLASMA_DIR/lib/python" |
There was a problem hiding this comment.
the directory structure should match, so this should either be
cp "$PLASMA_DIR/build/libplasma.so" "$PYTHON_PLASMA_DIR/build/"
or
cp "$PLASMA_DIR/lib/python/libplasma.so" "$PYTHON_PLASMA_DIR/lib/python/"
| @@ -37,4 +37,4 @@ elif [[ $platform == "macosx" ]]; then | |||
| fi | |||
|
|
|||
| sudo pip install --upgrade git+git://github.com/cloudpipe/cloudpickle.git@0d225a4695f1f65ae1cbb2e0bbc145e10167cce4 # We use the latest version of cloudpickle because it can serialize named tuples. | |||
| sudo pip install --upgrade --verbose git+git://github.com/ray-project/numbuf.git@d1974afbab9f0f1bcf8af15a8c476d868ad31aff | |||
There was a problem hiding this comment.
If you change this here, you should also change it in install-on-macos.md and install-on-ubuntu.md.
|
|
||
| def random_string(): | ||
| return "".join([chr(random.randint(0, 255)) for _ in range(20)]) |
There was a problem hiding this comment.
Purely aesthetic, but I think it'd be better to define random_string before random_object_id since random_object_id uses random_string.
| pushd "$PLASMA_DIR/build" | ||
| cmake .. | ||
| make install | ||
| popd | ||
| popd | ||
| cp "$PLASMA_DIR/build/plasma_store" "$PYTHON_PLASMA_DIR/build/" | ||
| cp "$PLASMA_DIR/build/plasma_manager" "$PYTHON_PLASMA_DIR/build/" |
There was a problem hiding this comment.
we no longer need to build plasma_client.so, right? Let's remove all references to that.
| def wait(self, object_ids, timeout, num_returns): | ||
| return libplasma.fetch(self.conn, object_ids) | ||
|
|
||
| def wait(self, object_ids, timeout=2**32-1, num_returns=1): |
There was a problem hiding this comment.
whitespace, just save a variable timeout = 2 ** 32 - 1 and then timeout=timeout.
There was a problem hiding this comment.
Also note that this is a bug. The timeout should be a 64 bit integer. But that doesn't work for some reason.
| int port, | ||
| object_id object_id); | ||
|
|
||
| /** |
There was a problem hiding this comment.
Wasn't this already here? If not, how were we doing the transfer tests before?
| (plasma_connection *) PyCapsule_GetPointer(capsule, "plasma"); | ||
| plasma_disconnect(conn); | ||
| */ | ||
| } |
There was a problem hiding this comment.
Any reason we can't implement this now?
| #include "common.h" | ||
| #include "plasma_client.h" | ||
|
|
||
| static int PyObjectToPlasma(PyObject *object, plasma_connection **conn) { |
There was a problem hiding this comment.
Should probably be PyObjectToPlasmaConnection, right?
| PyErr_SetString( | ||
| PyExc_RuntimeError, | ||
| "The argument num_returns cannot be greater than len(object_ids)"); | ||
| } |
There was a problem hiding this comment.
need to return NULL here, right?
| @@ -91,8 +91,12 @@ struct plasma_store_state { | |||
| plasma_store_info *plasma_store_info; | |||
| /** The state that is managed by the eviction policy. */ | |||
| eviction_state *eviction_state; | |||
| /** Input buffer. */ | |||
There was a problem hiding this comment.
please document the purpose of this
No description provided.