[Train] Fix the import path for LightningTrainer to be compatible with Pytorch Lightning 2.0. #34033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
matthewdeng
reviewed
Apr 4, 2023
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
gjoliver
approved these changes
Apr 4, 2023
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
…h Pytorch Lightning 2.0. (ray-project#34033) * fix import path Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com> Signed-off-by: elliottower <elliot@elliottower.com>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
…h Pytorch Lightning 2.0. (ray-project#34033) * fix import path Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com> Signed-off-by: Jack He <jackhe2345@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Pytorch Lightning released 2.0 a few weeks ago, and they have changed the import path of
ProgressBarBase, which could cause an import error if we do not take care of it.Given that PTL has removed all the documentations in 1.x, and many of our users are trying out PTL 2.0, it'd be necessary to ensure compatibility with the latest PTL version in release 2.4. This PR added version check and import
ProgressBarBasewith different paths accordingly.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.