Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick the OOM graph PR #34129

Merged

Conversation

rkooo567
Copy link
Contributor

@rkooo567 rkooo567 commented Apr 6, 2023

Add the OOM failure graph.

I added under the top section (task/actor) since it is much easier to discover + related to tasks and actors failures.

In the long term, we can replace this graph to failure type graph (e.g., include application failure, node failure, etc.).

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Add the OOM failure graph.

I added under the top section (task/actor) since it is much easier to discover + related to tasks and actors failures.

In the long term, we can replace this graph to failure type graph (e.g., include application failure, node failure, etc.).
@rkooo567 rkooo567 requested a review from a team as a code owner April 6, 2023 10:35
@clarng
Copy link
Contributor

clarng commented Apr 6, 2023

approved per #33999 (review)

@clarng
Copy link
Contributor

clarng commented Apr 6, 2023

@rkooo567 shall we fix dco?

@clarng clarng added the release-blocker P0 Issue that blocks the release label Apr 6, 2023
@rkooo567
Copy link
Contributor Author

rkooo567 commented Apr 7, 2023

I think it is okay. Let me just merge it!

@rkooo567 rkooo567 merged commit 8ae72ee into ray-project:releases/2.4.0 Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-blocker P0 Issue that blocks the release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants