Pass in actor creation dummy object for Java #3437
Conversation
| @@ -172,7 +172,7 @@ private static ByteBuffer convertTaskSpecToFlatbuffer(TaskSpec task) { | |||
| final int parentTaskIdOffset = fbb.createString(task.parentTaskId.toByteBuffer()); | |||
| final int parentCounter = task.parentCounter; | |||
| final int actorCreateIdOffset = fbb.createString(task.actorCreationId.toByteBuffer()); | |||
| final int actorCreateDummyIdOffset = fbb.createString(UniqueId.NIL.toByteBuffer()); | |||
| final int actorCreateDummyIdOffset = fbb.createString(task.actorId.toByteBuffer()); | |||
There was a problem hiding this comment.
The dummy object ID isn't actually the actor ID, right? It's the dummy object for the actor creation task.
There was a problem hiding this comment.
In the Python frontend, that's true, but it turns out that Java is actually using the dummy object ID as the actor ID here. I think it's actually nice to have some association like this.
There was a problem hiding this comment.
Oh I see, thanks.
There was a problem hiding this comment.
One thing I found useful about having this association is when I debug issues about actor reconstruction, I can easily find the actor creation task id from the actor id, and vice versa.
| @@ -172,7 +172,7 @@ private static ByteBuffer convertTaskSpecToFlatbuffer(TaskSpec task) { | |||
| final int parentTaskIdOffset = fbb.createString(task.parentTaskId.toByteBuffer()); | |||
| final int parentCounter = task.parentCounter; | |||
| final int actorCreateIdOffset = fbb.createString(task.actorCreationId.toByteBuffer()); | |||
| final int actorCreateDummyIdOffset = fbb.createString(UniqueId.NIL.toByteBuffer()); | |||
| final int actorCreateDummyIdOffset = fbb.createString(task.actorId.toByteBuffer()); | |||
There was a problem hiding this comment.
One thing I found useful about having this association is when I debug issues about actor reconstruction, I can easily find the actor creation task id from the actor id, and vice versa.
|
Test FAILed. |
|
Some tests failing, but the Java ones look good. |
What do these changes do?
Fixes #3434.
Also, Java has a nicer way of handling this in that the object ID returned by an actor creation task is automatically used as the actor ID. We should consider doing the same in Python.