Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in ray.wait #3445

Merged
merged 1 commit into from
Dec 2, 2018
Merged

Conversation

stephanie-wang
Copy link
Contributor

What do these changes do?

ray.wait depends on callbacks from the GCS to decide when an object has appeared in the cluster. The raylet crashes if a callback is received for a wait request that has already completed, but this actually can happen, depending on the order of calls. More precisely:

  1. Objects A and B are put in the cluster.
  2. Client calls ray.wait([A, B], num_returns=1).
  3. Client subscribes to locations for A and B. Locations are cached for both, so callbacks are posted for each.
  4. Callback for A fires. The wait completes and the request is removed.
  5. Callback for B fires. The wait request no longer exists and raylet crashes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/9683/
Test FAILed.

@robertnishihara
Copy link
Collaborator

@stephanie-wang is there a good way to test this?

@robertnishihara robertnishihara merged commit 4abafd7 into ray-project:master Dec 2, 2018
@robertnishihara robertnishihara deleted the fix-wait branch December 2, 2018 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants