Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Un-restrict virtualenv dep version as we skip pip 23.1.0 - 23.1.1 #34898

Closed
wants to merge 4 commits into from

Conversation

rickyyx
Copy link
Contributor

@rickyyx rickyyx commented May 1, 2023

Why are these changes needed?

Seems virtualenv didn't work with python3.10 on pip 23.1.0/1
pypa/virtualenv#2560

We could close it since we ping pip version now, and this should be resolved by #34655

Related issue number

Closes #34658

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: rickyyx <rickyx@anyscale.com>
@rickyyx rickyyx changed the title [ci] Un-restrict virtualenv dep version as a result of pip 23 [ci] Un-restrict virtualenv/pip dep version as a result of pip 23.1.2 fixes issues with 23.1 May 1, 2023
@rickyyx rickyyx changed the title [ci] Un-restrict virtualenv/pip dep version as a result of pip 23.1.2 fixes issues with 23.1 [ci] Un-restrict virtualenv dep version as a result of pip 23.1 May 1, 2023
Signed-off-by: rickyyx <rickyx@anyscale.com>
@rickyyx
Copy link
Contributor Author

rickyyx commented May 1, 2023

Looks like the failures are all unrelated.

@rickyyx rickyyx marked this pull request as ready for review May 1, 2023 13:37
@scv119 scv119 added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label May 1, 2023
@rickyyx rickyyx changed the title [ci] Un-restrict virtualenv dep version as a result of pip 23.1 [ci] Un-restrict virtualenv dep version as we skip pip 23.1.0/2 May 1, 2023
@rickyyx
Copy link
Contributor Author

rickyyx commented May 3, 2023

cc @ericl / @richardliaw / @edoakes for a stamp.

@rickyyx rickyyx removed the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label May 3, 2023
@rickyyx rickyyx changed the title [ci] Un-restrict virtualenv dep version as we skip pip 23.1.0/2 [ci] Un-restrict virtualenv dep version as we skip pip 23.1.0 - 23.1.1 May 3, 2023
@rickyyx rickyyx added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label May 4, 2023
Signed-off-by: rickyyx <rickyx@anyscale.com>
@rickyyx rickyyx marked this pull request as draft May 6, 2023 05:36
@stale
Copy link

stale bot commented Jun 10, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@stale stale bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Jun 10, 2023
@stale
Copy link

stale bot commented Aug 12, 2023

Hi again! The issue will be closed because there has been no more activity in the 14 days since the last message.

Please feel free to reopen or open a new issue if you'd still like it to be addressed.

Again, you can always ask for help on our discussion forum or Ray's public slack channel.

Thanks again for opening the issue!

@stale stale bot closed this Aug 12, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. stale The issue is stale. It will be closed within 7 days unless there are further conversation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[runtime-env] investigate why latest virtualenv breaks test_runtime_env_complicated
6 participants