Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Test Data notebook examples #35618

Merged
merged 6 commits into from
Jun 20, 2023
Merged

Conversation

bveeramani
Copy link
Member

@bveeramani bveeramani commented May 22, 2023

Why are these changes needed?

https://github.com/ray-project/ray/pull/33067/files#diff-23d840fadd8386e760a9e6e727860459768c58f4205391c32b6f8abd7d38a25f accidentally stopped testing Data notebook examples in CI. This PR reintroduces the tests.

Related issue number

See #36618, #36619

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani bveeramani marked this pull request as draft May 22, 2023 18:08
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani bveeramani marked this pull request as ready for review June 20, 2023 21:44
@bveeramani bveeramani added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Jun 20, 2023
@c21 c21 merged commit 6838568 into ray-project:master Jun 20, 2023
@c21
Copy link
Contributor

c21 commented Jun 20, 2023

Merged to master, thanks!

arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
https://github.com/ray-project/ray/pull/33067/files#diff-23d840fadd8386e760a9e6e727860459768c58f4205391c32b6f8abd7d38a25f accidentally stopped testing Data notebook examples in CI. This PR reintroduces the tests.

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants