Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] GCS version auth [5/n] #36073

Closed
wants to merge 6 commits into from
Closed

[core] GCS version auth [5/n] #36073

wants to merge 6 commits into from

Conversation

vitsai
Copy link
Contributor

@vitsai vitsai commented Jun 5, 2023

Add AuthType template parameter to authenticate against cluster token.

(Moved authentication logic over from #35014 to make the PR smaller.)

Why are these changes needed?

Related issue number

#34763

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@vitsai vitsai changed the title [core] GCS verison Auth [core] GCS version auth Jun 5, 2023
@vitsai vitsai mentioned this pull request Jun 5, 2023
Closed
8 tasks
@vitsai vitsai force-pushed the gcs-version-auth branch 4 times, most recently from 1bfd527 to 930a5c0 Compare June 5, 2023 17:05
@vitsai vitsai changed the title [core] GCS version auth [core] GCS version auth [5/n] Jun 17, 2023
@vitsai vitsai force-pushed the gcs-version-auth branch from 930a5c0 to 3d07e4a Compare June 22, 2023 22:01
@vitsai vitsai changed the base branch from master to gcs-version June 22, 2023 22:02
@vitsai vitsai force-pushed the gcs-version branch 3 times, most recently from 26bacf1 to cf7033c Compare June 30, 2023 06:15
@vitsai
Copy link
Contributor Author

vitsai commented Jul 1, 2023

cc: @bveeramani release-blocking PR

scv119
scv119 requested changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@scv119 scv119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also the merge conflict need to be fixed.

src/ray/gcs/gcs_client/accessor.h Show resolved Hide resolved
src/ray/gcs/gcs_client/gcs_client.h Outdated Show resolved Hide resolved
src/ray/raylet/main.cc
RAY_CHECK_OK(status);
RAY_CHECK(stored_raylet_config.has_value());
RayConfig::instance().initialize(stored_raylet_config.get());
auto f = std::async(std::launch::async, [&]() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason making this change?

src/ray/rpc/client_call.h
@@ -227,7 +244,7 @@ class ClientCallManager {
/// -1 means it will use the default timeout configured for the handler.
///
/// \return A `ClientCall` representing the request that was just sent.
template <class GrpcService, class Request, class Reply>
template <class GrpcService, class Request, class Reply, bool Insecure>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super nit: Insecure -> VerifyClusterId

@vitsai
fix rebase mistake
1cb5f26 
Signed-off-by: vitsai <victoria@anyscale.com>
@vitsai vitsai force-pushed the gcs-version-auth branch from de5b269 to 1cb5f26 Compare July 6, 2023 22:33
@fishbone fishbone deleted the branch ray-project:gcs-version July 10, 2023 20:54
fishbone pushed a commit that referenced this pull request Jul 10, 2023
@vitsai
[core] Retrieve the token from GCS server [4/n] (#37003)
4d8c2c9 
Retrieve the token from the GCS server in the GCS client while connecting, to attach to metadata in requests.

Previous PR (GCS server): #36535
Next PR (auth): #36073
@fishbone fishbone closed this Jul 10, 2023
Bhav00 pushed a commit to Bhav00/ray that referenced this pull request Jul 11, 2023
@vitsai @Bhav00
[core] Retrieve the token from GCS server [4/n] (ray-project#37003)
da64972 
Retrieve the token from the GCS server in the GCS client while connecting, to attach to metadata in requests.

Previous PR (GCS server): ray-project#36535
Next PR (auth): ray-project#36073

Signed-off-by: Bhavpreet Singh <singh.bhavpreet00@gmail.com>
vitsai added a commit that referenced this pull request Jul 11, 2023
@vitsai
[core] Retrieve the token from GCS server [4/n] (#37003)
0f09444 
Retrieve the token from the GCS server in the GCS client while connecting, to attach to metadata in requests.

Previous PR (GCS server): #36535
Next PR (auth): #36073
@vitsai vitsai mentioned this pull request Jul 11, 2023
Merged
8 tasks
vitsai added a commit that referenced this pull request Jul 11, 2023
@vitsai
[core] Retrieve the token from GCS server [4/n] (#37003) (#37294)
456f532 
Retrieve the token from the GCS server in the GCS client while connecting, to attach to metadata in requests.

Previous PR (GCS server): #36535
Next PR (auth): #36073
Bhav00 pushed a commit to Bhav00/ray that referenced this pull request Jul 28, 2023
@vitsai @Bhav00
[core] Retrieve the token from GCS server [4/n] (ray-project#37003)
dce17b7 
Retrieve the token from the GCS server in the GCS client while connecting, to attach to metadata in requests.

Previous PR (GCS server): ray-project#36535
Next PR (auth): ray-project#36073

Signed-off-by: Bhavpreet Singh <singh.bhavpreet00@gmail.com>
Bhav00 pushed a commit to Bhav00/ray that referenced this pull request Jul 28, 2023
@vitsai @Bhav00
[core] Retrieve the token from GCS server [4/n] (ray-project#37003)
8abe3f3 
Retrieve the token from the GCS server in the GCS client while connecting, to attach to metadata in requests.

Previous PR (GCS server): ray-project#36535
Next PR (auth): ray-project#36073

Signed-off-by: Bhavpreet Singh <singh.bhavpreet00@gmail.com>
NripeshN pushed a commit to NripeshN/ray that referenced this pull request Aug 15, 2023
@vitsai @NripeshN
[core] Retrieve the token from GCS server [4/n] (ray-project#37003)
4e2c8aa 
Retrieve the token from the GCS server in the GCS client while connecting, to attach to metadata in requests.

Previous PR (GCS server): ray-project#36535
Next PR (auth): ray-project#36073

Signed-off-by: NripeshN <nn2012@hw.ac.uk>
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
@vitsai @arvind-chandra
[core] Retrieve the token from GCS server [4/n] (ray-project#37003)
cfc8b0e 
Retrieve the token from the GCS server in the GCS client while connecting, to attach to metadata in requests.

Previous PR (GCS server): ray-project#36535
Next PR (auth): ray-project#36073

Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scv119 scv119 scv119 requested changes

Assignees

@scv119 scv119

@fishbone fishbone

Labels
@author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vitsai @scv119 @fishbone