Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deflake fork tests #36109

Closed
wants to merge 2 commits into from
Closed

Deflake fork tests #36109

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d645873
Deflake fork tests
pcmoritz Jun 6, 2023
0ebb5ff
update
pcmoritz Jun 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions python/ray/tests/test_basic_4.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,14 @@ def g():


@pytest.mark.skipif(
sys.platform == "win32",
reason="Fork is only supported on *nix systems.",
sys.platform != "linux",
# Even though fork is supported on macOS, in practice
# it has many problems, see
# https://github.com/python/cpython/issues/84559
# In truth, fork without exec should probably
# not even be used on linux. This pattern just has
# too many problems.
reason="Fork only works on linux.",
)
def test_fork_support(shutdown_only):
"""Test that fork support works."""
Expand Down