Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Delete object spilling dead code path. #36286

Merged
merged 1 commit into from
Jun 14, 2023
Merged

[core] Delete object spilling dead code path. #36286

merged 1 commit into from
Jun 14, 2023

Conversation

fishbone
Copy link
Contributor

@fishbone fishbone commented Jun 9, 2023 •
edited
Loading

Signed-off-by: Yi Cheng 74173148+iycheng@users.noreply.github.com

Why are these changes needed?

This code path is dead. Delete it.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@fishbone
fix
e5a4aa2 
Signed-off-by: Yi Cheng <74173148+iycheng@users.noreply.github.com>
@fishbone fishbone marked this pull request as ready for review June 12, 2023 19:03
jjyao
jjyao approved these changes Jun 14, 2023
View reviewed changes
Copy link
Collaborator

@jjyao jjyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@fishbone fishbone merged commit 088ce1b into ray-project:master Jun 14, 2023
@akshay-anyscale akshay-anyscale mentioned this pull request Jul 21, 2023
Closed
8 tasks
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
@fishbone @arvind-chandra
[core] Delete object spilling dead code path. (ray-project#36286)
f8516c0 
Signed-off-by: Yi Cheng <74173148+iycheng@users.noreply.github.com>

[core] Delete object spilling dead code path.

Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjyao jjyao jjyao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fishbone @jjyao