Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update typo in lightning_trainer.py #36310

Merged
merged 1 commit into from
Jun 14, 2023
Merged

Update typo in lightning_trainer.py #36310

merged 1 commit into from
Jun 14, 2023

Conversation

scottsun94
Copy link
Contributor

@scottsun94 scottsun94 commented Jun 11, 2023 •
edited
Loading

Why are these changes needed?

  1. typo
  2. we shouldn't use "trial" as a concept in train-only documentation. In other words, Ray Train users don't need to know "trial" unless they use Tune.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@scottsun94
Update typo in lightning_trainer.py
5781a3c 
Signed-off-by: Huaiwei Sun <scottsun94@gmail.com>
@scottsun94
Copy link
Contributor Author

Need someone to help merge. @matthewdeng

@jjyao jjyao merged commit 5d2ac7d into master Jun 14, 2023
@jjyao jjyao deleted the scottsun94-patch-1 branch June 14, 2023 04:20
@akshay-anyscale akshay-anyscale mentioned this pull request Jul 21, 2023
Closed
8 tasks
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
@scottsun94 @arvind-chandra
Update typo in lightning_trainer.py (ray-project#36310)
df71bcd 
- typo
- we shouldn't use "trial" as a concept in train-only documentation. In other words, Ray Train users don't need to know "trial" unless they use Tune.

Signed-off-by: Huaiwei Sun <scottsun94@gmail.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelinalg angelinalg angelinalg approved these changes

@woshiyyya woshiyyya woshiyyya approved these changes

@matthewdeng matthewdeng Awaiting requested review from matthewdeng matthewdeng is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scottsun94 @woshiyyya @angelinalg @jjyao