[ci][fix] avoid update test object before its run #36354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslonnie
reviewed
Jun 13, 2023
Comment on lines
+44
to
+46
| clone_test = copy.deepcopy(test) | ||
| clone_test.update_from_s3() | ||
| if clone_test.is_jailed_with_open_issue(TestStateMachine.get_ray_repo()): |
There was a problem hiding this comment.
any test to capture this behavior?
There was a problem hiding this comment.
Added tests \o/
can-anyscale
force-pushed
the
can-avoid-update
branch
from
8b65af9 to
75554c4
Compare
Signed-off-by: can <can@anyscale.com>
can-anyscale
force-pushed
the
can-avoid-update
branch
from
75554c4 to
7136f81
Compare
aslonnie
approved these changes
Jun 13, 2023
8 tasks
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
Signed-off-by: can <can@anyscale.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The current code execution sync the test object with s3 db, which then discard all local changes to the test definition that is un-sync with the latest copy stored in s3. This prevents any local change to be picked up.
Avoid update the test object in general.
Checks
git commit -s) in this PR.