[ci][fix] add --run-jailed-tests when build-pipeline invoke itself #36361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslonnie
approved these changes
Jun 13, 2023
Comment on lines
98
to
99
| if run_jailed_tests: | ||
| cmd += ["--run-jailed-tests"] |
Signed-off-by: can <can@anyscale.com>
matthewdeng
reviewed
Jun 14, 2023
Comment on lines
+243
to
+246
| def _get_rerun_cmd( | ||
| test_collection_file: Optional[str] = None, | ||
| run_jailed_tests: bool = False, | ||
| ): |
There was a problem hiding this comment.
Do you need to pass no_clone_repo as well?
There was a problem hiding this comment.
not really, that option is not used ;)
8 tasks
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
Signed-off-by: can <can@anyscale.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
build-pipeline script sometimes invoke itself, but does not inherit all the flag from its origin. Add the
--run-jailed-testswhen it invokes itself.Checks
git commit -s) in this PR.