[release/air] Upgrade release tests that depend on upgraded modin to py38 #36402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
|
Failing release test needs this issue to be solved still, but it's failing for other reasons. See this thread: #36254 |
justinvyu
added
the
tests-ok
krfricke
approved these changes
Jun 16, 2023
8 tasks
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
…y-project#36402) ray-project#30895 upgraded the pinned version of modin, removing support for python <= 3.7. All the release tests run with py37 by default, so the cluster env was failing to build due to no compatible modin version. This PR runs these release tests with py38 instead, which aligns with the us moving to testing with py38 for all of CI. Signed-off-by: Justin Yu <justinvyu@anyscale.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
#30895 upgraded the pinned version of
modin, removing support for python <= 3.7. All the release tests run with py37 by default, so the cluster env was failing to build due to no compatiblemodinversion. This PR runs these release tests with py38 instead, which aligns with the us moving to testing with py38 for all of CI.Related issue number
Closes #36299
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.