Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unskip test_get_release_wheel_url for mac #36430

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Conversation

jjyao
Copy link
Collaborator

@jjyao jjyao commented Jun 14, 2023

Why are these changes needed?

Unskip test_get_release_wheel_url for mac since now we have generated wheels ends with x86_64.whl

Related issue number

Closes #33396

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
@jjyao jjyao requested a review from rickyyx June 14, 2023 22:00
Copy link
Contributor

@rickyyx rickyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


via GIPHY

@jjyao jjyao merged commit 2b04fa2 into ray-project:master Jun 15, 2023
@jjyao jjyao deleted the jjyao/wheel branch June 15, 2023 03:41
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
Unskip test_get_release_wheel_url for mac since now we have generated wheels ends with x86_64.whl

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[core][runtime] Release wheel name for osx on py36 37 is not right.
2 participants