[Tests][Doc] Remove LightningTrainer PBT Examples and Test #36476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
woshiyyya
requested review from
richardliaw,
krfricke,
xwjiang2010,
amogkam,
matthewdeng,
Yard1,
maxpumperla and
a team
as code owners
justinvyu
approved these changes
Jun 21, 2023
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
|
@justinvyu OK, added a note in the example. Another option is to just open an issue and collect feedback if users are actively trying to get that to work. Or maybe make post in discuss.ray.io? |
matthewdeng
approved these changes
Jun 21, 2023
|
Created a tracking issue: #36660 |
8 tasks
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
…ct#36476) Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Removing the PBT example for LightningTrainer to fix the flaky release test
lightning_gpu_tune_3x16_3x1.aws.The perturbed learning rate set by PBT is also not used, since Lightning's optimizer state will be fully loaded back. In general, we should remove the samples and tests for LightningTrainer with PBT, since it currently doesn't actually do anything.
Kicked off a release test: https://buildkite.com/ray-project/release-tests-pr/builds/42409#0188c120-a83b-4233-ae49-b1b370db7bea
Related issue number
Closes #36403
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.