[ci] mark documentation test as soft fail #36480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has been consistently failing since the strict mode is turned back on. This will make other test fixes easier to spot. Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
aslonnie
requested review from
richardliaw,
bveeramani,
krfricke and
can-anyscale
|
@bveeramani : what do you think? |
|
Seems reasonable. I'm concerned that we might introduce more documentation issues, but if |
I/we will remove the |
|
@akshay-anyscale @scv119 looks like the the remaining build errors are with Serve, Workflows, and Observability. Do you think your respective teams will get a chance to address these in the near future? |
bveeramani
approved these changes
Jun 16, 2023
aslonnie
changed the title
8 tasks
8 tasks
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
It has been consistently failing since the strict mode is turned back on. This will make other test fixes easier to spot. Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been consistently failing since the strict mode is turned back on in cd0d3cd
This will make other test fixes easier to spot.