Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Fix a broken reference in Configure logging page #36489

Merged
merged 3 commits into from
Jun 30, 2023
Merged

[Doc] Fix a broken reference in Configure logging page #36489

merged 3 commits into from
Jun 30, 2023

Conversation

scottsun94
Copy link
Contributor

Why are these changes needed?

The reference uses the wrong syntax and is broken.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@scottsun94 scottsun94 requested a review from a team as a code owner June 16, 2023 03:33
@scottsun94 scottsun94 requested a review from angelinalg June 16, 2023 03:33
@scottsun94 scottsun94 force-pushed the scottsun94-patch-1 branch from d39c23c to 7071cd6 Compare June 21, 2023 02:49
@scottsun94
Fix a broken reference
88db59c 
Signed-off-by: Huaiwei Sun <scottsun94@gmail.com>
@scottsun94
fix another broken link
38d81b3 
Signed-off-by: Huaiwei Sun <scottsun94@gmail.com>
@scottsun94 scottsun94 force-pushed the scottsun94-patch-1 branch from 7071cd6 to 38d81b3 Compare June 26, 2023 20:29
@scottsun94
fix 2 more links
fed16cc 
Signed-off-by: Huaiwei Sun <scottsun94@gmail.com>
@rkooo567 rkooo567 merged commit 0159077 into master Jun 30, 2023
@rkooo567 rkooo567 deleted the scottsun94-patch-1 branch June 30, 2023 23:18
@akshay-anyscale akshay-anyscale mentioned this pull request Jul 21, 2023
Closed
8 tasks
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
@scottsun94 @arvind-chandra
[Doc] Fix a broken reference in Configure logging page (ray-project#3…
2fe106b 
…6489)

Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkooo567 rkooo567 rkooo567 approved these changes

@matthewdeng matthewdeng matthewdeng approved these changes

@angelinalg angelinalg Awaiting requested review from angelinalg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scottsun94 @matthewdeng @rkooo567