[core] Add ClusterID to ClientCallManager [2/n] #36526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitsai
requested review from
a team,
wuisawesome,
ericl,
AmeerHajAli and
robertnishihara
as code owners
vitsai
force-pushed
the
gcs-version-client-small
branch
3 times, most recently
from
4468331 to
ff1026e
Compare
8 tasks
fishbone
reviewed
Jun 17, 2023
8 tasks
vitsai
force-pushed
the
gcs-version-client-small
branch
from
89bd6ce to
7fb24fa
Compare
vitsai
changed the title
vitsai
force-pushed
the
gcs-version-client-small
branch
2 times, most recently
from
c002e55 to
41d8dbd
Compare
scv119
pushed a commit
that referenced
this pull request
Jun 20, 2023
First of a stack of changes to plumb through token exchange between GCS client and server. This adds a ClusterID token that can be passed to a GRPC server, which then initializes each component GRPC service with the token by passing to the ServerCallFactory objects when they are set up. When the factories create ServerCall objects for the GRPC service completion queue, this token is also passed to the ServerCall to check against inbound request metadata. The actual authentication check does not take place in this PR. Note: This change also minorly cleans up some code in GCS server (changes a string check to use an enum). Next change (client-side analogue): #36526
Signed-off-by: vitsai <victoria@anyscale.com>
Signed-off-by: vitsai <victoria@anyscale.com>
Signed-off-by: vitsai <victoria@anyscale.com>
Signed-off-by: vitsai <victoria@anyscale.com>
Signed-off-by: vitsai <victoria@anyscale.com>
Signed-off-by: vitsai <victoria@anyscale.com>
vitsai
added a commit
that referenced
this pull request
Jun 30, 2023
[core] Add ClusterID token to GRPC server [1/n] (#36517) First of a stack of changes to plumb through token exchange between GCS client and server. This adds a ClusterID token that can be passed to a GRPC server, which then initializes each component GRPC service with the token by passing to the ServerCallFactory objects when they are set up. When the factories create ServerCall objects for the GRPC service completion queue, this token is also passed to the ServerCall to check against inbound request metadata. The actual authentication check does not take place in this PR. Note: This change also minorly cleans up some code in GCS server (changes a string check to use an enum). Next change (client-side analogue): #36526 [core] Generate GCS server token Signed-off-by: vitsai <victoria@anyscale.com> Add client-side logic for setting cluster ID. Signed-off-by: vitsai <victoria@anyscale.com> bug fixes Signed-off-by: vitsai <victoria@anyscale.com> comments Signed-off-by: vitsai <victoria@anyscale.com> bug workaround Signed-off-by: vitsai <victoria@anyscale.com> Fix windows build Signed-off-by: vitsai <victoria@anyscale.com> fix bug Signed-off-by: vitsai <victoria@anyscale.com> remove auth stuff from this pr Signed-off-by: vitsai <victoria@anyscale.com> fix mock build Signed-off-by: vitsai <victoria@anyscale.com> comments Signed-off-by: vitsai <victoria@anyscale.com> remove future Signed-off-by: vitsai <victoria@anyscale.com> Remove top-level changes Signed-off-by: vitsai <victoria@anyscale.com> comments Signed-off-by: vitsai <victoria@anyscale.com> Peel back everything that's not grpc-layer changes Signed-off-by: vitsai <victoria@anyscale.com> Change atomic to mutex Signed-off-by: vitsai <victoria@anyscale.com> Fix alignment of SafeClusterID Signed-off-by: vitsai <victoria@anyscale.com> comments Signed-off-by: vitsai <victoria@anyscale.com> Add back everything in GCS server except RPC definition Signed-off-by: vitsai <victoria@anyscale.com> fix bug Signed-off-by: vitsai <victoria@anyscale.com> comments Signed-off-by: vitsai <victoria@anyscale.com> comments Signed-off-by: vitsai <victoria@anyscale.com> Add client-side stuff Signed-off-by: vitsai <victoria@anyscale.com> hack workaround to simulate async direct dispatch love when things hang Signed-off-by: vitsai <victoria@anyscale.com>
fishbone
pushed a commit
that referenced
this pull request
Jun 30, 2023
Add support for a GetClusterId RPC call in the GCS server that clients can use to obtain the cluster ID. In particular, GCS server will retrieve the cluster id from the persistent store if it exists, or otherwise generate a new one and store it. Previous PR (GRPC client): #36526 Next PR (GCS client): #35014 Part 3 of breaking down #35014 into more digestible parts.
vitsai
added a commit
to vitsai/ray
that referenced
this pull request
Jul 1, 2023
[core] Add ClusterID token to GRPC server [1/n] (ray-project#36517) First of a stack of changes to plumb through token exchange between GCS client and server. This adds a ClusterID token that can be passed to a GRPC server, which then initializes each component GRPC service with the token by passing to the ServerCallFactory objects when they are set up. When the factories create ServerCall objects for the GRPC service completion queue, this token is also passed to the ServerCall to check against inbound request metadata. The actual authentication check does not take place in this PR. Note: This change also minorly cleans up some code in GCS server (changes a string check to use an enum). Next change (client-side analogue): ray-project#36526 [core] Generate GCS server token Signed-off-by: vitsai <victoria@anyscale.com> Add client-side logic for setting cluster ID. Signed-off-by: vitsai <victoria@anyscale.com> bug fixes Signed-off-by: vitsai <victoria@anyscale.com> comments Signed-off-by: vitsai <victoria@anyscale.com> bug workaround Signed-off-by: vitsai <victoria@anyscale.com> Fix windows build Signed-off-by: vitsai <victoria@anyscale.com> fix bug Signed-off-by: vitsai <victoria@anyscale.com> remove auth stuff from this pr Signed-off-by: vitsai <victoria@anyscale.com> fix mock build Signed-off-by: vitsai <victoria@anyscale.com> comments Signed-off-by: vitsai <victoria@anyscale.com> remove future Signed-off-by: vitsai <victoria@anyscale.com> Remove top-level changes Signed-off-by: vitsai <victoria@anyscale.com> comments Signed-off-by: vitsai <victoria@anyscale.com> Peel back everything that's not grpc-layer changes Signed-off-by: vitsai <victoria@anyscale.com> Change atomic to mutex Signed-off-by: vitsai <victoria@anyscale.com> Fix alignment of SafeClusterID Signed-off-by: vitsai <victoria@anyscale.com> comments Signed-off-by: vitsai <victoria@anyscale.com> Add back everything in GCS server except RPC definition Signed-off-by: vitsai <victoria@anyscale.com> fix bug Signed-off-by: vitsai <victoria@anyscale.com> comments Signed-off-by: vitsai <victoria@anyscale.com> comments Signed-off-by: vitsai <victoria@anyscale.com>
vitsai
added a commit
to vitsai/ray
that referenced
this pull request
Jul 1, 2023
[core] Add ClusterID token to GRPC server [1/n] (ray-project#36517) First of a stack of changes to plumb through token exchange between GCS client and server. This adds a ClusterID token that can be passed to a GRPC server, which then initializes each component GRPC service with the token by passing to the ServerCallFactory objects when they are set up. When the factories create ServerCall objects for the GRPC service completion queue, this token is also passed to the ServerCall to check against inbound request metadata. The actual authentication check does not take place in this PR. Note: This change also minorly cleans up some code in GCS server (changes a string check to use an enum). Next change (client-side analogue): ray-project#36526 [core] Generate GCS server token Signed-off-by: vitsai <victoria@anyscale.com> Add client-side logic for setting cluster ID. Signed-off-by: vitsai <victoria@anyscale.com> bug fixes Signed-off-by: vitsai <victoria@anyscale.com> comments Signed-off-by: vitsai <victoria@anyscale.com> bug workaround Signed-off-by: vitsai <victoria@anyscale.com> Fix windows build Signed-off-by: vitsai <victoria@anyscale.com> fix bug Signed-off-by: vitsai <victoria@anyscale.com> remove auth stuff from this pr Signed-off-by: vitsai <victoria@anyscale.com> fix mock build Signed-off-by: vitsai <victoria@anyscale.com> comments Signed-off-by: vitsai <victoria@anyscale.com> remove future Signed-off-by: vitsai <victoria@anyscale.com> Remove top-level changes Signed-off-by: vitsai <victoria@anyscale.com> comments Signed-off-by: vitsai <victoria@anyscale.com> Peel back everything that's not grpc-layer changes Signed-off-by: vitsai <victoria@anyscale.com> Change atomic to mutex Signed-off-by: vitsai <victoria@anyscale.com> Fix alignment of SafeClusterID Signed-off-by: vitsai <victoria@anyscale.com> comments Signed-off-by: vitsai <victoria@anyscale.com> Add back everything in GCS server except RPC definition Signed-off-by: vitsai <victoria@anyscale.com> fix bug Signed-off-by: vitsai <victoria@anyscale.com> comments Signed-off-by: vitsai <victoria@anyscale.com> comments Signed-off-by: vitsai <victoria@anyscale.com> Add client-side stuff Signed-off-by: vitsai <victoria@anyscale.com> hack workaround to simulate async direct dispatch love when things hang Signed-off-by: vitsai <victoria@anyscale.com>
vitsai
added a commit
to vitsai/ray
that referenced
this pull request
Jul 6, 2023
[core] Add ClusterID token to GRPC server [1/n] (ray-project#36517) First of a stack of changes to plumb through token exchange between GCS client and server. This adds a ClusterID token that can be passed to a GRPC server, which then initializes each component GRPC service with the token by passing to the ServerCallFactory objects when they are set up. When the factories create ServerCall objects for the GRPC service completion queue, this token is also passed to the ServerCall to check against inbound request metadata. The actual authentication check does not take place in this PR. Note: This change also minorly cleans up some code in GCS server (changes a string check to use an enum). Next change (client-side analogue): ray-project#36526 [core] Generate GCS server token Signed-off-by: vitsai <victoria@anyscale.com> Add client-side logic for setting cluster ID. Signed-off-by: vitsai <victoria@anyscale.com> bug fixes Signed-off-by: vitsai <victoria@anyscale.com> comments Signed-off-by: vitsai <victoria@anyscale.com> bug workaround Signed-off-by: vitsai <victoria@anyscale.com> Fix windows build Signed-off-by: vitsai <victoria@anyscale.com> fix bug Signed-off-by: vitsai <victoria@anyscale.com> remove auth stuff from this pr Signed-off-by: vitsai <victoria@anyscale.com> fix mock build Signed-off-by: vitsai <victoria@anyscale.com> comments Signed-off-by: vitsai <victoria@anyscale.com> remove future Signed-off-by: vitsai <victoria@anyscale.com> Remove top-level changes Signed-off-by: vitsai <victoria@anyscale.com> comments Signed-off-by: vitsai <victoria@anyscale.com> Peel back everything that's not grpc-layer changes Signed-off-by: vitsai <victoria@anyscale.com> Change atomic to mutex Signed-off-by: vitsai <victoria@anyscale.com> Fix alignment of SafeClusterID Signed-off-by: vitsai <victoria@anyscale.com> comments Signed-off-by: vitsai <victoria@anyscale.com> Add back everything in GCS server except RPC definition Signed-off-by: vitsai <victoria@anyscale.com> fix bug Signed-off-by: vitsai <victoria@anyscale.com> comments Signed-off-by: vitsai <victoria@anyscale.com> comments Signed-off-by: vitsai <victoria@anyscale.com>
vitsai
added a commit
to vitsai/ray
that referenced
this pull request
Jul 6, 2023
[core] Add ClusterID token to GRPC server [1/n] (ray-project#36517) First of a stack of changes to plumb through token exchange between GCS client and server. This adds a ClusterID token that can be passed to a GRPC server, which then initializes each component GRPC service with the token by passing to the ServerCallFactory objects when they are set up. When the factories create ServerCall objects for the GRPC service completion queue, this token is also passed to the ServerCall to check against inbound request metadata. The actual authentication check does not take place in this PR. Note: This change also minorly cleans up some code in GCS server (changes a string check to use an enum). Next change (client-side analogue): ray-project#36526 [core] Generate GCS server token Signed-off-by: vitsai <victoria@anyscale.com> Add client-side logic for setting cluster ID. Signed-off-by: vitsai <victoria@anyscale.com> bug fixes Signed-off-by: vitsai <victoria@anyscale.com> comments Signed-off-by: vitsai <victoria@anyscale.com> bug workaround Signed-off-by: vitsai <victoria@anyscale.com> Fix windows build Signed-off-by: vitsai <victoria@anyscale.com> fix bug Signed-off-by: vitsai <victoria@anyscale.com> remove auth stuff from this pr Signed-off-by: vitsai <victoria@anyscale.com> fix mock build Signed-off-by: vitsai <victoria@anyscale.com> comments Signed-off-by: vitsai <victoria@anyscale.com> remove future Signed-off-by: vitsai <victoria@anyscale.com> Remove top-level changes Signed-off-by: vitsai <victoria@anyscale.com> comments Signed-off-by: vitsai <victoria@anyscale.com> Peel back everything that's not grpc-layer changes Signed-off-by: vitsai <victoria@anyscale.com> Change atomic to mutex Signed-off-by: vitsai <victoria@anyscale.com> Fix alignment of SafeClusterID Signed-off-by: vitsai <victoria@anyscale.com> comments Signed-off-by: vitsai <victoria@anyscale.com> Add back everything in GCS server except RPC definition Signed-off-by: vitsai <victoria@anyscale.com> fix bug Signed-off-by: vitsai <victoria@anyscale.com> comments Signed-off-by: vitsai <victoria@anyscale.com> comments Signed-off-by: vitsai <victoria@anyscale.com> Add client-side stuff Signed-off-by: vitsai <victoria@anyscale.com> hack workaround to simulate async direct dispatch love when things hang Signed-off-by: vitsai <victoria@anyscale.com>
vitsai
added a commit
to vitsai/ray
that referenced
this pull request
Jul 6, 2023
[core] Add ClusterID token to GRPC server [1/n] (ray-project#36517) First of a stack of changes to plumb through token exchange between GCS client and server. This adds a ClusterID token that can be passed to a GRPC server, which then initializes each component GRPC service with the token by passing to the ServerCallFactory objects when they are set up. When the factories create ServerCall objects for the GRPC service completion queue, this token is also passed to the ServerCall to check against inbound request metadata. The actual authentication check does not take place in this PR. Note: This change also minorly cleans up some code in GCS server (changes a string check to use an enum). Next change (client-side analogue): ray-project#36526 [core] Generate GCS server token Signed-off-by: vitsai <victoria@anyscale.com> Add client-side logic for setting cluster ID. Signed-off-by: vitsai <victoria@anyscale.com> bug fixes Signed-off-by: vitsai <victoria@anyscale.com> comments Signed-off-by: vitsai <victoria@anyscale.com> bug workaround Signed-off-by: vitsai <victoria@anyscale.com> Fix windows build Signed-off-by: vitsai <victoria@anyscale.com> fix bug Signed-off-by: vitsai <victoria@anyscale.com> remove auth stuff from this pr Signed-off-by: vitsai <victoria@anyscale.com> fix mock build Signed-off-by: vitsai <victoria@anyscale.com> comments Signed-off-by: vitsai <victoria@anyscale.com> remove future Signed-off-by: vitsai <victoria@anyscale.com> Remove top-level changes Signed-off-by: vitsai <victoria@anyscale.com> comments Signed-off-by: vitsai <victoria@anyscale.com> Peel back everything that's not grpc-layer changes Signed-off-by: vitsai <victoria@anyscale.com> Change atomic to mutex Signed-off-by: vitsai <victoria@anyscale.com> Fix alignment of SafeClusterID Signed-off-by: vitsai <victoria@anyscale.com> comments Signed-off-by: vitsai <victoria@anyscale.com> Add back everything in GCS server except RPC definition Signed-off-by: vitsai <victoria@anyscale.com> fix bug Signed-off-by: vitsai <victoria@anyscale.com> comments Signed-off-by: vitsai <victoria@anyscale.com> comments Signed-off-by: vitsai <victoria@anyscale.com>
vitsai
added a commit
to vitsai/ray
that referenced
this pull request
Jul 10, 2023
[core] Add ClusterID token to GRPC server [1/n] (ray-project#36517) First of a stack of changes to plumb through token exchange between GCS client and server. This adds a ClusterID token that can be passed to a GRPC server, which then initializes each component GRPC service with the token by passing to the ServerCallFactory objects when they are set up. When the factories create ServerCall objects for the GRPC service completion queue, this token is also passed to the ServerCall to check against inbound request metadata. The actual authentication check does not take place in this PR. Note: This change also minorly cleans up some code in GCS server (changes a string check to use an enum). Next change (client-side analogue): ray-project#36526 [core] Generate GCS server token Signed-off-by: vitsai <victoria@anyscale.com> Add client-side logic for setting cluster ID. Signed-off-by: vitsai <victoria@anyscale.com> bug fixes Signed-off-by: vitsai <victoria@anyscale.com> comments Signed-off-by: vitsai <victoria@anyscale.com> bug workaround Signed-off-by: vitsai <victoria@anyscale.com> Fix windows build Signed-off-by: vitsai <victoria@anyscale.com> fix bug Signed-off-by: vitsai <victoria@anyscale.com> remove auth stuff from this pr Signed-off-by: vitsai <victoria@anyscale.com> fix mock build Signed-off-by: vitsai <victoria@anyscale.com> comments Signed-off-by: vitsai <victoria@anyscale.com> remove future Signed-off-by: vitsai <victoria@anyscale.com> Remove top-level changes Signed-off-by: vitsai <victoria@anyscale.com> comments Signed-off-by: vitsai <victoria@anyscale.com> Peel back everything that's not grpc-layer changes Signed-off-by: vitsai <victoria@anyscale.com> Change atomic to mutex Signed-off-by: vitsai <victoria@anyscale.com> Fix alignment of SafeClusterID Signed-off-by: vitsai <victoria@anyscale.com> comments Signed-off-by: vitsai <victoria@anyscale.com> Add back everything in GCS server except RPC definition Signed-off-by: vitsai <victoria@anyscale.com> fix bug Signed-off-by: vitsai <victoria@anyscale.com> comments Signed-off-by: vitsai <victoria@anyscale.com> comments Signed-off-by: vitsai <victoria@anyscale.com>
vitsai
added a commit
to vitsai/ray
that referenced
this pull request
Jul 10, 2023
[core] Add ClusterID token to GRPC server [1/n] (ray-project#36517) First of a stack of changes to plumb through token exchange between GCS client and server. This adds a ClusterID token that can be passed to a GRPC server, which then initializes each component GRPC service with the token by passing to the ServerCallFactory objects when they are set up. When the factories create ServerCall objects for the GRPC service completion queue, this token is also passed to the ServerCall to check against inbound request metadata. The actual authentication check does not take place in this PR. Note: This change also minorly cleans up some code in GCS server (changes a string check to use an enum). Next change (client-side analogue): ray-project#36526 [core] Generate GCS server token Signed-off-by: vitsai <victoria@anyscale.com> Add client-side logic for setting cluster ID. Signed-off-by: vitsai <victoria@anyscale.com> bug fixes Signed-off-by: vitsai <victoria@anyscale.com> comments Signed-off-by: vitsai <victoria@anyscale.com> bug workaround Signed-off-by: vitsai <victoria@anyscale.com> Fix windows build Signed-off-by: vitsai <victoria@anyscale.com> fix bug Signed-off-by: vitsai <victoria@anyscale.com> remove auth stuff from this pr Signed-off-by: vitsai <victoria@anyscale.com> fix mock build Signed-off-by: vitsai <victoria@anyscale.com> comments Signed-off-by: vitsai <victoria@anyscale.com> remove future Signed-off-by: vitsai <victoria@anyscale.com> Remove top-level changes Signed-off-by: vitsai <victoria@anyscale.com> comments Signed-off-by: vitsai <victoria@anyscale.com> Peel back everything that's not grpc-layer changes Signed-off-by: vitsai <victoria@anyscale.com> Change atomic to mutex Signed-off-by: vitsai <victoria@anyscale.com> Fix alignment of SafeClusterID Signed-off-by: vitsai <victoria@anyscale.com> comments Signed-off-by: vitsai <victoria@anyscale.com> Add back everything in GCS server except RPC definition Signed-off-by: vitsai <victoria@anyscale.com> fix bug Signed-off-by: vitsai <victoria@anyscale.com> comments Signed-off-by: vitsai <victoria@anyscale.com> comments Signed-off-by: vitsai <victoria@anyscale.com>
8 tasks
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
First of a stack of changes to plumb through token exchange between GCS client and server. This adds a ClusterID token that can be passed to a GRPC server, which then initializes each component GRPC service with the token by passing to the ServerCallFactory objects when they are set up. When the factories create ServerCall objects for the GRPC service completion queue, this token is also passed to the ServerCall to check against inbound request metadata. The actual authentication check does not take place in this PR. Note: This change also minorly cleans up some code in GCS server (changes a string check to use an enum). Next change (client-side analogue): ray-project#36526 Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
This change adds a Cluster ID to GRPC client (client call, client call manager), and attaches it to the metadata of each ClientCall provided it is non-nil. Previous PR (GRPC server): ray-project#36517 Next PR (GCS server): ray-project#36535 Part 2 of breaking down ray-project#35014 into more digestible parts. Related issue number ray-project#34763 Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
Add support for a GetClusterId RPC call in the GCS server that clients can use to obtain the cluster ID. In particular, GCS server will retrieve the cluster id from the persistent store if it exists, or otherwise generate a new one and store it. Previous PR (GRPC client): ray-project#36526 Next PR (GCS client): ray-project#35014 Part 3 of breaking down ray-project#35014 into more digestible parts. Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a Cluster ID to GRPC client (client call, client call manager), and attaches it to the metadata of each ClientCall provided it is non-nil.
Previous PR (GRPC server): #36517
Next PR (GCS server): #36535
Part 2 of breaking down #35014 into more digestible parts.
Related issue number
#34763
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.