Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Remove grpcio import from usage_lib #36542

Merged
merged 1 commit into from
Jun 19, 2023
Merged

[Core] Remove grpcio import from usage_lib #36542

merged 1 commit into from
Jun 19, 2023

Conversation

pcmoritz
Copy link
Contributor

Why are these changes needed?

This is needed for #35472

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@pcmoritz pcmoritz requested a review from vitsai June 18, 2023 05:03
@pcmoritz pcmoritz merged commit 1529f1d into ray-project:master Jun 19, 2023
@pcmoritz pcmoritz deleted the usage-lib-remove-grpcio branch June 19, 2023 22:22
@akshay-anyscale akshay-anyscale mentioned this pull request Jul 21, 2023
Closed
8 tasks
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
@pcmoritz @arvind-chandra
[Core] Remove grpcio import from usage_lib (ray-project#36542)
6ab15eb 
This is needed for ray-project#35472

Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericl ericl ericl approved these changes

@richardliaw richardliaw Awaiting requested review from richardliaw richardliaw is a code owner

@rkooo567 rkooo567 Awaiting requested review from rkooo567 rkooo567 is a code owner

@jjyao jjyao Awaiting requested review from jjyao jjyao is a code owner

@vitsai vitsai Awaiting requested review from vitsai

Assignees

@vitsai vitsai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pcmoritz @ericl @vitsai