[ci] remove bazel_version subcommand in setup.py __api__ #36549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just parse bazel from .bazeliskrc Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
aslonnie
force-pushed
the
lonnie-0618-bazelver
branch
from
a068ba7 to
6ab4edd
Compare
Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
|
ping @richardliaw @edoakes @ericl for feedback or approval. |
edoakes
approved these changes
Jun 21, 2023
aslonnie
added
the
tests-ok
8 tasks
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
…#36549) * [ci] remove bazel_version subcommand in setup.py __api__ Just parse bazel from .bazeliskrc Signed-off-by: Lonnie Liu <lonnie@anyscale.com> * Fix bazel version picking Signed-off-by: Lonnie Liu <lonnie@anyscale.com> * fix lint Signed-off-by: Lonnie Liu <lonnie@anyscale.com> --------- Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just directly parse bazel version from .bazeliskrc
this properly sync's the bazel version, and might get better bazel cache hit rate.