Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core]Fix the error message prompt for command-line parameters in JSON format(--resources) #36550

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

larrylian
Copy link
Contributor

@larrylian larrylian commented Jun 19, 2023

Why are these changes needed?

  1. Fix error info: double }
    image

  2. Different shells may have different rules for command line parsing. As a result, there may be a difference between the string entered by the user and the string passed to the python script. So when an error is reported, the resources string is printed out to prompt the user.

  3. Increase the error reporting of json format parsing exception

image

Related issue number

Custom Resources from using ray start in CLI do not work as intended #36374

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

…N format(--resources)

Signed-off-by: LarryLian <554538252@qq.com>
Copy link
Collaborator

@jjyao jjyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jjyao jjyao merged commit 0466ebe into ray-project:master Jun 23, 2023
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
…N format(--resources) (ray-project#36550)

Signed-off-by: LarryLian <554538252@qq.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants