Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci][byod] migrate many rllib tests to byod #36560

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Conversation

can-anyscale
Copy link
Collaborator

@can-anyscale can-anyscale commented Jun 20, 2023

Why are these changes needed?

BYOD is a better way of running release tests. Migrate many rllib tests to BYOD.

Test run: https://buildkite.com/ray-project/release-tests-pr/builds/42840

Any tests that failed has been omitted from this migration

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • Testing Strategy
    • Unit tests
    • Release tests

@can-anyscale can-anyscale force-pushed the can-byod-rllib-tests branch 6 times, most recently from 1ee1ef6 to 1bc9c84 Compare June 21, 2023 00:11
@can-anyscale can-anyscale changed the title Can byod rllib tests [ci][byod] migrate many rllib tests to byod Jun 21, 2023
@can-anyscale can-anyscale changed the base branch from master to can-byod-ml-tests-02 June 21, 2023 00:13
@can-anyscale can-anyscale marked this pull request as ready for review June 21, 2023 00:13
@can-anyscale can-anyscale requested a review from a team as a code owner June 21, 2023 00:13
Copy link
Collaborator

@aslonnie aslonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@can-anyscale can-anyscale force-pushed the can-byod-ml-tests-02 branch from 4613fc0 to 141f10b Compare June 21, 2023 23:47
@can-anyscale can-anyscale force-pushed the can-byod-rllib-tests branch from 1bc9c84 to 68e3690 Compare June 21, 2023 23:48
@can-anyscale can-anyscale added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Jun 21, 2023
@can-anyscale can-anyscale force-pushed the can-byod-ml-tests-02 branch 2 times, most recently from 70ed167 to ad6a51e Compare June 21, 2023 23:56
@can-anyscale can-anyscale force-pushed the can-byod-rllib-tests branch from 68e3690 to 78abd93 Compare June 21, 2023 23:56
@can-anyscale can-anyscale force-pushed the can-byod-ml-tests-02 branch from ad6a51e to 1d01bb7 Compare June 21, 2023 23:59
@can-anyscale can-anyscale force-pushed the can-byod-rllib-tests branch from 78abd93 to 327609d Compare June 22, 2023 00:05
Base automatically changed from can-byod-ml-tests-02 to master June 22, 2023 00:09
Signed-off-by: can <can@anyscale.com>
@can-anyscale can-anyscale force-pushed the can-byod-rllib-tests branch from 327609d to 8d0c641 Compare June 22, 2023 00:10
@richardliaw richardliaw merged commit dbc0df4 into master Jun 22, 2023
@richardliaw richardliaw deleted the can-byod-rllib-tests branch June 22, 2023 00:12
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
Signed-off-by: can <can@anyscale.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants