Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci][py11/2] support docker build image for arm64 #36586

Merged
merged 2 commits into from
Jun 26, 2023
Merged

[ci][py11/2] support docker build image for arm64 #36586

merged 2 commits into from
Jun 26, 2023

Conversation

can-anyscale
Copy link
Collaborator

@can-anyscale can-anyscale commented Jun 20, 2023 •
edited
Loading

Why are these changes needed?

Support py311 docker build on arm64. On arm64, py311 needs g++ to compile grpc

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • Testing Strategy
    • Unit tests

@can-anyscale can-anyscale changed the base branch from master to can-docker-py11 June 20, 2023 21:31
@can-anyscale can-anyscale marked this pull request as ready for review June 20, 2023 21:31
@can-anyscale can-anyscale requested review from a team and rickyyx June 20, 2023 21:31
@can-anyscale can-anyscale changed the title Can docker py11 02 [ci][py11/2] support docker build image for arm64 Jun 20, 2023
rickyyx
rickyyx approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@rickyyx rickyyx left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which CI jobs should we be looking at for this change?


via GIPHY

@can-anyscale
Copy link
Collaborator Author

@rickyyx should be the py311[aarch64], there are two of those

@can-anyscale can-anyscale requested review from krfricke, a team and aslonnie as code owners June 21, 2023 17:43
@can-anyscale can-anyscale force-pushed the can-docker-py11 branch 3 times, most recently from 8e06cd2 to 4b1066a Compare June 21, 2023 20:47
aslonnie
aslonnie approved these changes Jun 21, 2023
View reviewed changes
docker/base-deps/Dockerfile Outdated Show resolved Hide resolved
@can-anyscale can-anyscale force-pushed the can-docker-py11 branch 4 times, most recently from c4ac061 to 7bbb49a Compare June 22, 2023 22:15
@can-anyscale can-anyscale force-pushed the can-docker-py11-02 branch 3 times, most recently from 9259c5f to b5e6730 Compare June 23, 2023 00:00
Base automatically changed from can-docker-py11 to master June 23, 2023 13:45
@can-anyscale
Support docker build for 3.11
2a3e042 
Signed-off-by: can <can@anyscale.com>
@can-anyscale
Support python 3.11 for arm64 machines
76b891f 
Signed-off-by: can <can@anyscale.com>
@richardliaw richardliaw merged commit 2f84fa3 into master Jun 26, 2023
@richardliaw richardliaw deleted the can-docker-py11-02 branch June 26, 2023 20:55
@akshay-anyscale akshay-anyscale mentioned this pull request Jul 21, 2023
Closed
8 tasks
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
@can-anyscale @arvind-chandra
[ci][py11/2] support docker build image for arm64 (ray-project#36586)
f42f012 
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aslonnie aslonnie aslonnie approved these changes

@rickyyx rickyyx rickyyx approved these changes

@krfricke krfricke Awaiting requested review from krfricke

Assignees

@rickyyx rickyyx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@can-anyscale @rickyyx @aslonnie @richardliaw