Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[observability doc] Improve the wording and fix typos #36593

Merged
merged 1 commit into from
Jun 26, 2023
Merged

[observability doc] Improve the wording and fix typos #36593

merged 1 commit into from
Jun 26, 2023

Conversation

scottsun94
Copy link
Contributor

Why are these changes needed?

Fix typos. Improve the confusing wording.

Related issue number

Close #36576

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@scottsun94 scottsun94 requested a review from a team as a code owner June 20, 2023 18:23
@scottsun94 scottsun94 mentioned this pull request Jun 20, 2023
Closed
@scottsun94
Improve the wording and fix typos
ddb4dd3 
Signed-off-by: Huaiwei Sun <scottsun94@gmail.com>
@scottsun94 scottsun94 force-pushed the scottsun94-patch-4 branch from 7c8d8ad to ddb4dd3 Compare June 21, 2023 02:52
@scottsun94
Copy link
Contributor Author

cc: @alanwguo @angelinalg ready for review

angelinalg
angelinalg approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@angelinalg angelinalg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catches!

@rkooo567 rkooo567 merged commit 156c39a into master Jun 26, 2023
@rkooo567 rkooo567 deleted the scottsun94-patch-4 branch June 26, 2023 21:44
@akshay-anyscale akshay-anyscale mentioned this pull request Jul 21, 2023
Closed
8 tasks
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
@scottsun94 @arvind-chandra
Improve the wording and fix typos (ray-project#36593)
0e3f3e3 
Fix typos. Improve the confusing wording.

Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelinalg angelinalg angelinalg approved these changes

@alanwguo alanwguo Awaiting requested review from alanwguo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[<Ray component:Monitoring and debuggging>] There seems to be a wrong description of the word
3 participants
@scottsun94 @angelinalg @rkooo567