-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core][devex] Move ray/util build targets to separate build files #36598
Conversation
Is there a master issue that describes this effort? e.g., what problems are we going to resolve? and the execution plan. For this particular PR, it seems to me that the only benefit is to slim the the BUILD file. And I don't see why I can't do it in place. |
Created #36611 to track this. Looks like it can be done incrementally in place after all; the mistake was putting BUILD files in the src and ray directories. Once you put a BUILD file in a directory, all targets building that subtree cannot be in a BUILD file in an ancestor of that directory. However, it seems like there is a way to skip the |
Skipping '//:logging_test': no such target '//:logging_test': target 'logging_test' not declared in package '' defined by /ray/BUILD.bazel test failure looks related. |
Signed-off-by: vitsai <victoria@anyscale.com>
Nice, it is great that you can do it without moving the source tree :) |
…ay-project#36598) Signed-off-by: vitsai <victoria@anyscale.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Why are these changes needed?
Some build file cleanup before we separate out into finer targets.
Related issue number
#36611
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.