Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core][devex] Move ray/util build targets to separate build files #36598

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

vitsai
Copy link
Contributor

@vitsai vitsai commented Jun 20, 2023

Why are these changes needed?

Some build file cleanup before we separate out into finer targets.

Related issue number

#36611

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@raulchen
Copy link
Contributor

Is there a master issue that describes this effort? e.g., what problems are we going to resolve? and the execution plan.

For this particular PR, it seems to me that the only benefit is to slim the the BUILD file. And I don't see why I can't do it in place.

@vitsai
Copy link
Contributor Author

vitsai commented Jun 20, 2023

Created #36611 to track this.

Looks like it can be done incrementally in place after all; the mistake was putting BUILD files in the src and ray directories. Once you put a BUILD file in a directory, all targets building that subtree cannot be in a BUILD file in an ancestor of that directory.

However, it seems like there is a way to skip the src and ray directories the way the protobuf folder has done.

@vitsai vitsai changed the title [core][devex] Start new src tree to incrementally fix build files [core][devex] Move ray/util build targets to separate build files Jun 20, 2023
src/ray/util/test/BUILD Outdated Show resolved Hide resolved
@scv119 scv119 added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Jun 21, 2023
@scv119
Copy link
Contributor

scv119 commented Jun 21, 2023

Skipping '//:logging_test': no such target '//:logging_test': target 'logging_test' not declared in package '' defined by /ray/BUILD.bazel

test failure looks related.

Signed-off-by: vitsai <victoria@anyscale.com>
@vitsai vitsai removed the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Jun 21, 2023
@pcmoritz
Copy link
Contributor

Nice, it is great that you can do it without moving the source tree :)

@jjyao jjyao merged commit 7f6fbf0 into ray-project:master Jun 21, 2023
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
…ay-project#36598)

Signed-off-by: vitsai <victoria@anyscale.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants