[tune][dashboard] upgrade tensorboardX to 2.6.0 #36643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
due to protobuf compatibility issue. Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
|
Thanks for fixing this! Also ouch we are running into dependency hell: |
|
Even Google's own TensorFlow is running into protobuf hell, quite telling: |
aslonnie
changed the title
aslonnie
changed the title
sihanwang41
reviewed
Jun 21, 2023
python/requirements.txt
Outdated
| @@ -53,7 +53,7 @@ scikit-image | |||
| prometheus_client>=0.7.1 | |||
| requests | |||
| pandas | |||
| tensorboardX>=1.9 | |||
| tensorboardX<=2.6.0,>=1.9 | |||
There was a problem hiding this comment.
can you add a comment why we need to pin? so that we can easily get the context for future upgrading.
Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
|
there are many other tests on master that are breaking now, so I honestly do not really know if this pr's change is breaking the tests even more.. @scv119 , how is your progress on fixing master? |
8 tasks
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
which unpins protobuf and uses protobuf>=4 fixes ray-project#36658 --------- Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which unpins protobuf and uses protobuf>=4
fixes #36658