[core][autoscaler] GCS Autoscaler V2: Add node type name to ray #36714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickyyx
requested review from
a team,
wuisawesome,
DmitriGekhtman,
ericl,
AmeerHajAli,
robertnishihara,
pcmoritz and
raulchen
as code owners
rickyyx
commented
Jun 23, 2023
| @@ -96,12 +96,14 @@ message NodeState { | |||
|
|
|||
| // The instance id that the node is running on. | |||
| // This is passed in when the node is registered. | |||
| // Set by ray from ENV at src/ray/common/constants.h::kNodeCloudInstanceIdEnv | |||
There was a problem hiding this comment.
scv119
approved these changes
Jun 24, 2023
8 tasks
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
…project#36714) Why are these changes needed? This PR adds way to pass instance type (ray node type name) to ray, and make it available to autoscaler. I will be adding e2e tests in a separate PR (from installer -> GCS -> autoscaler). This PR only adds the unit testing. --------- Signed-off-by: rickyyx <rickyx@anyscale.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR adds way to pass instance type (ray node type name) to ray, and make it available to autoscaler.
I will be adding e2e tests in a separate PR (from installer -> GCS -> autoscaler). This PR only adds the unit testing.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.