Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serve] Remove unnecessary capitalization in status message #36746

Merged

Conversation

shrekris-anyscale
Copy link
Contributor

Why are these changes needed?

This change removes unnecessary capitalization in a status message.

Related issue number

N/A

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • This change only modifies a status message. It doesn't change behavior.

Signed-off-by: Shreyas Krishnaswamy <shrekris@anyscale.com>
@shrekris-anyscale shrekris-anyscale changed the title [Serve] Remove spurious capitalization in status message [Serve] Remove unnecessary capitalization in status message Jun 23, 2023
@shrekris-anyscale shrekris-anyscale removed the request for review from zcin June 23, 2023 01:30
@shrekris-anyscale
Copy link
Contributor Author

The failures are unrelated:

  • Lint was failing on master:
Screen Shot 2023-06-23 at 11 22 28 AM Screen Shot 2023-06-23 at 11 22 54 AM

@shrekris-anyscale
Copy link
Contributor Author

@architkulkarni @edoakes this change is ready to merge.

@architkulkarni architkulkarni merged commit 7919407 into ray-project:master Jun 23, 2023
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
This change removes unnecessary capitalization in a status message.

Signed-off-by: Shreyas Krishnaswamy <shrekris@anyscale.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants