Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[air/output] Add newlines between status blocks #36765

Merged
merged 4 commits into from
Jun 23, 2023
Merged

[air/output] Add newlines between status blocks #36765

merged 4 commits into from
Jun 23, 2023

Conversation

krfricke
Copy link
Contributor

Why are these changes needed?

Adds newlines between status output blocks and fixes a phrasing issue with the train reporter.

Related issue number

Closes #36755

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@krfricke krfricke requested review from justinvyu and scottsun94 June 23, 2023 13:24
@krfricke krfricke mentioned this pull request Jun 23, 2023
Closed
Kai Fricke added 2 commits June 23, 2023 15:43
[air/output] Enhance formatting/phrasing
968f6a6 
Signed-off-by: Kai Fricke <kai@anyscale.com>
remove second training
729b5d1 
Signed-off-by: Kai Fricke <kai@anyscale.com>
@krfricke krfricke force-pushed the air/output/formatting branch from 07abe53 to 729b5d1 Compare June 23, 2023 14:43
Kai Fricke added 2 commits June 23, 2023 15:48
revert
c43b88e 
Signed-off-by: Kai Fricke <kai@anyscale.com>
nl
b003663 
Signed-off-by: Kai Fricke <kai@anyscale.com>
@krfricke krfricke merged commit c682770 into ray-project:master Jun 23, 2023
@krfricke krfricke deleted the air/output/formatting branch June 23, 2023 19:21
@krfricke krfricke mentioned this pull request Jun 26, 2023
Closed
@scottsun94 scottsun94 mentioned this pull request Jun 26, 2023
Closed
@akshay-anyscale akshay-anyscale mentioned this pull request Jul 21, 2023
Closed
8 tasks
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
@krfricke @arvind-chandra
[air/output] Add newlines between status blocks (ray-project#36765)
ee54a0a 
Adds newlines between status output blocks and fixes a phrasing issue with the train reporter.

Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinvyu justinvyu justinvyu approved these changes

@scottsun94 scottsun94 Awaiting requested review from scottsun94

Assignees

@justinvyu justinvyu

@scottsun94 scottsun94

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[AIR Output] Formatting issues for training output
3 participants
@krfricke @justinvyu @scottsun94