[Dashboard] Update Serve System UI #36787
Conversation
- Add logs to the main serve page - Put serve system details on a separate tab, but show a preview on the main Serve page Signed-off-by: Alan Guo <aguo@anyscale.com>
|
Still need to write tests, but ready for UX review @scottsun94 |
|
Do we still show all statuses and their counts (instead of showing only 3 as we discussed)? Other changes look good. |
Decided to just show all states. Since you mentioned you were okay with the contents wrapping to the next line, it's easier to just show all states. |
|
@alanwguo Can we add a 4px padding for each chip/pill so that it looks less crowded? |
|
Signed-off-by: Alan Guo <aguo@anyscale.com>
|
LGTM. |
| {serveDetails.http_options === undefined ? ( | ||
| <Alert className={classes.serveInstanceWarning} severity="warning"> | ||
| Serve not started. Please deploy a serve application first. | ||
| </Alert> | ||
| ) : ( | ||
| <React.Fragment> | ||
| <ServeSystemDetails | ||
| serveDetails={serveDetails} | ||
| <ServeSystemPreview |
There was a problem hiding this comment.
Shouldn't ServeSystemPreview be shown in ServeSystemDetailPage instead? Along with the logs panel (title="Logs")
We can also remove having Serve applications be a collapsible section, and make the title of the page Applications instead (similar to System tab)
There was a problem hiding this comment.
We can also remove having Serve applications be a collapsible section, and make the title of the page Applications instead (similar to System tab)
Serve applications -> Applications makes sense.
Let's keep the collapsable behavior for now since it doesn't hurt? I don't know if people might want to collapse it when the table is long and they just want to focus on logs and metrics.
|
|
Signed-off-by: Alan Guo <aguo@anyscale.com>
|
@galenhwang , please re-review |
|
@rkooo567 ready for merge! |
Signed-off-by: Alan Guo <aguo@anyscale.com>
|
Added an additional change to expand deployments by default in some cases. Will ping once tests pass |
Add logs to the main serve page Put serve system details on a separate tab, but show a preview on the main Serve page Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Why are these changes needed?
Related issue number
fixes #36630
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.