[Data] Define optimizer rules with global variables #36920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulchen
requested review from
ericl,
scv119,
c21,
amogkam,
scottjlee and
bveeramani
as code owners
scottjlee
approved these changes
Jun 28, 2023
Signed-off-by: Hao Chen <chenh1024@gmail.com>
raulchen
force-pushed
the
optimizer-rule-config
branch
from
800cac5 to
3b3c3b9
Compare
|
Tests failure look irrelevant, merging to master. |
8 tasks
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
We've temporarily disabled the limit-push-down rule. With this change, users can enable it manually by modifying these 2 variables, in case the it is useful. Later, we should consider providing a public API for users to configure the rules. Signed-off-by: Hao Chen <chenh1024@gmail.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
We've temporarily disabled the limit-push-down rule. With this change, users can enable it manually by modifying these 2 variables, in case the it is useful. Later, we should consider providing a public API for users to configure the rules.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.