Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Fix the unnecessary logs #36931

Merged
merged 1 commit into from
Jul 7, 2023
Merged

[Core] Fix the unnecessary logs #36931

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ray/gcs/gcs_server/gcs_job_manager.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,8 +224,8 @@ void GcsJobManager::HandleGetAllJobInfo(rpc::GetAllJobInfoRequest request,
const Status &status,
const rpc::NumPendingTasksReply &num_pending_tasks_reply) {
if (!status.ok()) {
RAY_LOG(ERROR) << "Failed to get is_running_tasks from core worker: "
<< status.ToString();
RAY_LOG(WARNING) << "Failed to get is_running_tasks from core worker: "
<< status.ToString();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, if the status is not ok, should we early return, seems the current code keeps executing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not handle it in this PR and make a follow-up? This error message actually impacts the user experience, so let's make sure we merge this PR first. cc @architkulkarni to follow up with this comment (we probably want to fix that by 2.6 as well).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jjyao @rkooo567 In the case of returning early from status not ok for one of the jobs:

  • should we set is_running_tasks to True or False?
  • should we set the status in the overall reply (which contains info for all the jobs) to OK, or something else?

Also, why should it be a 2.6 release blocker? Will it crash if it doesn't return early?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should reply OK but have a special flag to indicate the result is not known.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the ERROR log is a release blocker. This can easily happen under common cases, and ERROR logs will make drivers spammy. I already saw this message frequently from CI tests.

}
bool is_running_tasks = num_pending_tasks_reply.num_pending_tasks() > 0;
reply->mutable_job_info_list(i)->set_is_running_tasks(is_running_tasks);
Expand Down