Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Pin joblib to 1.2.0 in CI #36932

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

shrekris-anyscale
Copy link
Contributor

Why are these changes needed?

test_joblib has been failing master over the past day:

Screen Shot 2023-06-28 at 5 44 13 PM

Reverting the first PR that failed still doesn't fix the tests (see revert PR). The cause is likely that a new joblib version was released today (1.3.0), causing the test to start failing. Thanks @rkooo567 for catching this, and thanks @can-anyscale for giving pointers on what files to change.

This change pins joblib to 1.2.0 in the CI. It should fix test_joblib.

Related issue number

N/A

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
      • test_joblib should start passing.

Signed-off-by: Shreyas Krishnaswamy <shrekris@anyscale.com>
Copy link
Contributor

@rkooo567 rkooo567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests pass. Also cc @matthewdeng for the follow-up (or lmk if you guys don't own this)

@shrekris-anyscale
Copy link
Contributor Author

All tests pass.

@rkooo567 @matthewdeng this change is ready to merge.

@matthewdeng matthewdeng merged commit cd4682b into ray-project:master Jun 29, 2023
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
Signed-off-by: Shreyas Krishnaswamy <shrekris@anyscale.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants