[Core] Add a better error message for health checking network failures #36957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SangBin Cho <rkooo567@gmail.com>
fishbone
approved these changes
Jun 29, 2023
Signed-off-by: SangBin Cho <rkooo567@gmail.com>
rkooo567
added a commit
to rkooo567/ray
that referenced
this pull request
Jul 12, 2023
ray-project#36957) This PR adds a better error message for health checking network failures Currently, it doesn't log why health check RPCs fail.
8 tasks
8 tasks
NripeshN
pushed a commit
to NripeshN/ray
that referenced
this pull request
Aug 15, 2023
ray-project#36957) This PR adds a better error message for health checking network failures Currently, it doesn't log why health check RPCs fail. Signed-off-by: NripeshN <nn2012@hw.ac.uk>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
ray-project#36957) This PR adds a better error message for health checking network failures Currently, it doesn't log why health check RPCs fail. Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR adds a better error message for health checking network failures
Currently, it doesn't log why health check RPCs fail.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.