[data] Cache Dataset.schema #37103
Merged
[data] Cache Dataset.schema #37103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanie-wang
requested review from
ericl,
scv119,
c21,
amogkam,
scottjlee,
bveeramani and
raulchen
as code owners
scottjlee
approved these changes
Jul 5, 2023
ericl
reviewed
Jul 5, 2023
| if self._stages_after_snapshot: | ||
| # TODO(swang): There are several other stage types that could |
There was a problem hiding this comment.
Yeah, was wondering if this should be a feature of the LogicalPlan API (cc @raulchen ).
ericl
reviewed
Jul 5, 2023
| @@ -241,6 +241,22 @@ def test_schema_lazy(ray_start_regular_shared): | |||
| assert ds._plan.execute()._num_computed() == 0 | |||
|
|
|||
|
|
|||
| def test_schema_cached(ray_start_regular_shared): | |||
| def check_schema_cached(ds): | |||
| schema = ds.schema() | |||
There was a problem hiding this comment.
Should we also check that repeated calls to schema() are cached?
There was a problem hiding this comment.
Ah it is checked under this.
ericl
approved these changes
Jul 5, 2023
ericl
added
the
@author-action-required
stephanie-wang
added a commit
to stephanie-wang/ray
that referenced
this pull request
Jul 7, 2023
Cache the computed schema to avoid re-executing. Closes ray-project#37077.
bveeramani
pushed a commit
that referenced
this pull request
Jul 7, 2023
8 tasks
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
Cache the computed schema to avoid re-executing. Closes ray-project#37077. Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Cache the computed schema to avoid re-executing.
Related issue number
Closes #37077.
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.