[core][autoscaler] Fix idle time duration when node resource is not updated periodically #37121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickyyx
requested review from
a team,
wuisawesome,
DmitriGekhtman,
ericl,
AmeerHajAli,
robertnishihara,
pcmoritz and
raulchen
as code owners
rickyyx
commented
Jul 5, 2023
scv119
reviewed
Jul 6, 2023
scv119
added
the
@author-action-required
rickyyx
force-pushed
the
pr-auto-fix-idle-time
branch
from
deaf106 to
127c9d6
Compare
rickyyx
removed
the
@author-action-required
scv119
approved these changes
Jul 6, 2023
rickyyx
added a commit
to rickyyx/ray
that referenced
this pull request
Jul 6, 2023
…pdated periodically (ray-project#37121) Why are these changes needed? It was assumed resource update is broadcasted periodically (which isn't the case), so the idle time wasn't updated when the node keeps in the idle state. This PR makes the raylet sent the last idle time (if idle) to the GCS, and allows GCS to calculate the duration. --------- Signed-off-by: rickyyx <rickyx@anyscale.com>
bveeramani
pushed a commit
that referenced
this pull request
Jul 10, 2023
…pdated periodically (#37121) (#37175) Why are these changes needed? It was assumed resource update is broadcasted periodically (which isn't the case), so the idle time wasn't updated when the node keeps in the idle state. This PR makes the raylet sent the last idle time (if idle) to the GCS, and allows GCS to calculate the duration. --------- Signed-off-by: rickyyx <rickyx@anyscale.com>
8 tasks
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
…pdated periodically (ray-project#37121) Why are these changes needed? It was assumed resource update is broadcasted periodically (which isn't the case), so the idle time wasn't updated when the node keeps in the idle state. This PR makes the raylet sent the last idle time (if idle) to the GCS, and allows GCS to calculate the duration. --------- Signed-off-by: rickyyx <rickyx@anyscale.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
It was assumed resource update is broadcasted periodically (which isn't the case), so the idle time wasn't updated when the node keeps in the idle state.
This PR makes the raylet sent the last idle time (if idle) to the GCS, and allows GCS to calculate the duration.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.