[RLlib] Cherry pick rllib test fixes 2 6 #37154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n test larger (ray-project#37127) Signed-off-by: Avnish <avnishnarayan@gmail.com>
avnishn
requested review from
sven1977,
gjoliver,
ArturNiederfahrenhorst,
smorad,
maxpumperla,
kouroshHakha and
krfricke
as code owners
This was
linked to
issues
Jul 6, 2023
|
Do you need to change the wait_for_node in release_tests.yaml |
can-anyscale
reviewed
Jul 6, 2023
| max_workers: 1 | ||
| instance_type: g3s.xlarge | ||
| min_workers: 2 | ||
| max_workers: 2 |
There was a problem hiding this comment.
oh hmm if you change the number of workers here, you need to change the wait_for_node in release_tests.yaml as well
There was a problem hiding this comment.
oh shucks. It seems to have all worked out though?
There was a problem hiding this comment.
tests were previously passing.
There was a problem hiding this comment.
yes, in theory it will be a data race bug so it might or might not happen
This was referenced Jul 6, 2023
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes for #37078 and #37039
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.